wip: add airbnb eslint configuration #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int eslint-plugin-import eslint-config-airbnb
marcusmolchany
changed the title
nicholasgubbins
approved these changes
Aug 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
This change adds the eslint-config-airbnb linting configuration. Linting can now be ran using the script
npm run lint.TODO: fix all linting errors (in another commit) and make
npm run lintthe precursor tonpm test.Part of #2
How did you implement it:
npm installed
eslint-config-airbnbas per their docs and raneslint --fix .at the top level.How can we verify it:
TODO: we should definitely test that everything still works
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO