Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rule pack info generation #44

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Fix rule pack info generation #44

merged 5 commits into from
Jun 6, 2024

Conversation

bensonce
Copy link
Contributor

@bensonce bensonce commented Jun 5, 2024 •
edited
Loading

  • Refactored the rule pack info generation script to use the same rule names as the ones in the TF locals block. For example, the cloud-trail-enabled rules that are in the pack-rules.yaml file should now match the cloudtrail-enabled rule name in the managed_rules_locals.tf file.
  • Consolidated rule pack info updates and config rules updates into a single GHA workflow
  • The update-rule-packs step now depends on the update-config-rules step because the rule names aren't present in the conformance packs, only their identifiers.

This should address the concerns raised in this PR: #43

@bensonce bensonce marked this pull request as ready for review June 5, 2024 17:24
@bensonce bensonce requested review from duraikkannuv2 and yangx17 June 5, 2024 17:24
@bensonce bensonce self-assigned this Jun 5, 2024
@bensonce bensonce added the bug Something isn't working label Jun 5, 2024
yangx17
yangx17 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@yangx17 yangx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many changes are for rule name fixing to match the latest AWS configure rule documents... overall looks good to me! Thank you!

@bensonce bensonce merged commit b4177db into main Jun 6, 2024
5 checks passed
@bensonce bensonce deleted the f/fix-rule-pack-info-generator branch June 6, 2024 15:19
@bensonce bensonce mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangx17 yangx17 yangx17 approved these changes

@duraikkannuv2 duraikkannuv2 Awaiting requested review from duraikkannuv2

Assignees

@bensonce bensonce

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bensonce @yangx17