Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect relative paths set in index.py #39

Merged
merged 1 commit into from
May 23, 2024

Conversation

bensonce
Copy link
Contributor

@bensonce bensonce commented May 23, 2024

There was an issue in the latest run of the Update Config Rules workflow:

Writing result to config_rule_data.json.
File not found:  [Errno 2] No such file or directory: '../../managed_rules_locals.tf'
Traceback (most recent call last):
  File "/home/runner/work/terraform-aws-managed-config-rules/terraform-aws-managed-config-rules/scripts/index.py", line 24, in <module>
    for _, local in enumerate(data['locals']):
KeyError: 'locals'
Error: Process completed with exit code 1.

I've updated the file paths to use the scripts directory to build absolute paths to the managed_rules_locals.tf and managed_rules_variables.tf files.

Here is a successful run of the updated workflow: https://github.com/niaid/terraform-aws-managed-config-rules/actions/runs/9208135752/job/25329687982

@bensonce bensonce self-assigned this May 23, 2024
@bensonce bensonce added the bug Something isn't working label May 23, 2024
@bensonce bensonce requested a review from duraikkannuv2 May 23, 2024 12:47
Copy link
Contributor

@duraikkannuv2 duraikkannuv2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bensonce bensonce merged commit 0c9346d into main May 23, 2024
6 checks passed
@bensonce bensonce deleted the fix/broken-file-paths branch May 23, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants