-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow for updating rules #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for adding this. We need to also update the conformance pack by running the script scripts/generate-rule-pack-info.rb
Good idea! I've added a new workflow for that here too. This one is manually triggered but also opens a new PR with any changes. I rewrote the script in Python and reorganized the scripts to all be in the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Added a workflow that runs every two weeks to update the list of managed rules. If changes are found then a PR is opened and reviewers are automatically assigned. If for some reason no one reviews the PR before the next workflow run, the workflow should update the existing PR with changes again so multiple PRs aren't cluttering the repo.
The first PR using this workflow can be found here: #31