Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for updating rules #30

Merged
merged 15 commits into from
May 13, 2024
Merged

Conversation

bensonce
Copy link
Contributor

@bensonce bensonce commented Apr 30, 2024

Added a workflow that runs every two weeks to update the list of managed rules. If changes are found then a PR is opened and reviewers are automatically assigned. If for some reason no one reviews the PR before the next workflow run, the workflow should update the existing PR with changes again so multiple PRs aren't cluttering the repo.

The first PR using this workflow can be found here: #31

@bensonce bensonce marked this pull request as ready for review April 30, 2024 20:49
@bensonce bensonce added the enhancement New feature or request label Apr 30, 2024
@bensonce bensonce self-assigned this Apr 30, 2024
Copy link
Contributor

@duraikkannuv2 duraikkannuv2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding this. We need to also update the conformance pack by running the script scripts/generate-rule-pack-info.rb

@bensonce
Copy link
Contributor Author

bensonce commented May 3, 2024

Looks good. Thanks for adding this. We need to also update the conformance pack by running the script scripts/generate-rule-pack-info.rb

Good idea! I've added a new workflow for that here too. This one is manually triggered but also opens a new PR with any changes. I rewrote the script in Python and reorganized the scripts to all be in the same scripts directory. The new rule_pack_info_generator.py script was tested locally and behaves the same as the old Ruby script. You can test it locally yourself to see the changes, too.

Copy link
Contributor

@duraikkannuv2 duraikkannuv2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bensonce bensonce merged commit 8341396 into main May 13, 2024
2 checks passed
@bensonce bensonce deleted the ci/update-config-rules-on-a-schedule branch May 13, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants