Merge pull request #79 from niaid/staging

NDS 1.1.9 Release
niaid · Feb 16, 2023 · e78b75c · e78b75c
2 parents eb5bf89 + 8461367
commit e78b75c
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 19 deletions.
diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
 # NIAID Design System (NDS)
 
-VERSION 1.1.8
+VERSION 1.1.9
 
 The [NIAID Design System](http://nds.niaid.nih.gov.s3-website-us-east-1.amazonaws.com/) was developed within the Office of Communications and Government Relations (OCGR) at the National Institute of Allergy and Infectious Diseases (NIAID) by Booz Allen Hamilton. The design system is designed to aid users with the process of creating policy-compliant websites that conform to design standards and guidance set by NIAID, NIH, HHS, and USWDS.
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "niaid-design-system",
-    "version": "1.1.8",
+    "version": "1.1.9",
     "description": "NIAID Design System",
     "main": "public/index.html",
     "dependencies": {

diff --git a/src/_patterns/00-nds/01-atoms/buttons/button-share/button-share.scss b/src/_patterns/00-nds/01-atoms/buttons/button-share/button-share.scss
@@ -71,7 +71,4 @@
             height: $s-1;
         }
     }
-    & .ext-link-icon {
-        display: none;
-    }
 }
diff --git a/src/_patterns/00-nds/01-atoms/input/input-checkbox/input-checkbox.scss b/src/_patterns/00-nds/01-atoms/input/input-checkbox/input-checkbox.scss
@@ -41,21 +41,14 @@
 }
 
 @mixin input-checkbox-focus {
-    outline: none;
-    &:focus,
-    &:focus-within {
-        input + label::before {
-            outline-color: Highlight;
-            outline-color: -webkit-focus-ring-color;
-            outline-offset: 1px;
-            outline-style: solid;
-            outline-width: 2px;
-        }
-    }
+    outline-color: Highlight;
+    outline-color: -webkit-focus-ring-color;
+    outline-offset: 1px;
+    outline-style: solid;
+    outline-width: 2px;
 }
 
 .input--checkbox {
-    @include input-checkbox-focus;
     position: relative;
     margin: $s-0-50 0;
     &:first-child {
@@ -67,6 +60,14 @@
         height: 0;
         width: 0;
     }
+    input.check {
+        outline: none;
+        &:focus {
+            + .input--label::before {
+                @include input-checkbox-focus;
+            }
+        }
+    }
     .input--label,
     label {
         @include input-checkbox-label;

diff --git a/src/_patterns/00-nds/01-atoms/links/link-external/link-external.js b/src/_patterns/00-nds/01-atoms/links/link-external/link-external.js
@@ -12,8 +12,9 @@ var moduleNDS_links = (function() {
                 initDocumentLink(externalLinks[i]);
                 let url = externalLinks[i].getAttribute('href');
                 let hostname = externalLinks[i].hostname;
-                let urlclassname = externalLinks[i].classList.contains('icon-nds') === true;
-                if (url && hostname !== location.hostname && urlclassname !== true) {
+                let buttonclassname = externalLinks[i].classList.contains('button-nds') === true;
+                let iconclassname = externalLinks[i].classList.contains('icon-nds') === true;
+                if (url && hostname !== location.hostname && iconclassname !== true && buttonclassname !== true) {
                     url = url.toLowerCase();
                     if (((url.indexOf('http://') > -1) || (url.indexOf('https://')) > -1) && (url.indexOf('localhost:3002') <= 0))  {
                         externalLinks[i].setAttribute('target', '_blank');

diff --git a/src/_patterns/00-nds/01-atoms/tables/table-default/table-default.scss b/src/_patterns/00-nds/01-atoms/tables/table-default/table-default.scss
@@ -28,6 +28,8 @@ table {
         th {
             line-height: normal;
             a {
+                border-bottom-color: $white;
+                color: $white;
                 span {
                     &.tablesort {
                         background-image: none;
@@ -49,6 +51,22 @@ table {
                         }
                     }
                 }
+                &:hover,
+                &:focus,
+                &:active {
+                    border-bottom: $border-transparent;
+                    color: $white;
+                }
+                &:visited {
+                    border-bottom-color: $white;
+                    color: $white;
+                    &:hover,
+                    &:focus {
+                        border-bottom: $border-transparent;
+                        color: $white;
+                    }
+                }
+
             }
             &.is-active {
                 a {
@@ -59,6 +77,9 @@ table {
         td {
             color: $type-body;
             border: $border-block;
+            &.is-active {
+                background-color: $grey-100;
+            }
         }
         &:last-child {
             td {