Merge remote-tracking branch 'upstream/v2' into v2-sync

.editorconfig

@@ -25,6 +25,13 @@ spaces_around_brackets = none
 indent_brace_style = allman
 
 
+# JavaScript/TypeScript
+[*.{js,ts}]
+indent_style = space
+curly_bracket_next_line = false
+indent_brace_style = K&R
+
+
 # JSON/YAML
 [*.{json,babelrc,code-workspace,yml,yaml}]
 indent_style = space

.eslintrc.yml

@@ -14,7 +14,9 @@ parserOptions:
   project: ./tsconfig.json
 rules: # https://eslint.org/docs/rules/
   accessor-pairs: error
-  array-bracket-newline: error
+  array-bracket-newline:
+  - error
+  - consistent
   array-bracket-spacing:
   - error
   - never
@@ -29,9 +31,7 @@ rules: # https://eslint.org/docs/rules/
     before: true
   block-scoped-var: error
   block-spacing: error
-  brace-style:
-  - error
-  - allman
+  brace-style: 'off' # see "@typescript-eslint/brace-style"
   callback-return: error
   capitalized-comments: 'off'
   class-methods-use-this: error
@@ -87,26 +87,14 @@ rules: # https://eslint.org/docs/rules/
   - below
   indent:
   - error
-  - tab
+  - 4
+  - SwitchCase: 1
   indent-legacy: 'off'
   init-declarations: error
   jsx-quotes: error
   key-spacing: error
   keyword-spacing:
   - error
-  - overrides:
-      catch:
-        after: false
-      for:
-        after: false
-      if:
-        after: false
-      switch:
-        after: false
-      while:
-        after: false
-      with:
-        after: false
   line-comment-position: 'off'
   linebreak-style:
   - error
@@ -173,7 +161,7 @@ rules: # https://eslint.org/docs/rules/
   - error
   - max: 1
   no-native-reassign: error
-  no-negated-condition: error
+  no-negated-condition: 'off'
   no-negated-in-lhs: error
   no-nested-ternary: error
   no-new: error
@@ -256,7 +244,7 @@ rules: # https://eslint.org/docs/rules/
   rest-spread-spacing:
   - error
   - never
-  semi: error
+  semi: 'off' # see "@typescript-eslint/semi"
   semi-spacing: error
   semi-style:
   - error
@@ -308,8 +296,25 @@ rules: # https://eslint.org/docs/rules/
 
   # @typescript-eslint plugin
   "@typescript-eslint/ban-ts-ignore": 'off'
+  "@typescript-eslint/brace-style":
+  - error
+  - 1tbs
+  "@typescript-eslint/member-delimiter-style":
+  - error
+  - multiline:
+      delimiter: semi
+      requireLast: true
+    singleline:
+      delimiter: semi
+      requireLast: true
   "@typescript-eslint/no-empty-interface": 'off'
+  "@typescript-eslint/no-floating-promises": error
   "@typescript-eslint/no-use-before-define":
   - error
   - functions: false
-  "@typescript-eslint/strict-boolean-expressions": error
+  "@typescript-eslint/semi": error
+  "@typescript-eslint/strict-boolean-expressions":
+  - error
+  - allowString: false
+    allowNumber: false
+    allowNullableObject: false

.github/actions/cache-npm/action.yml

@@ -0,0 +1,25 @@
+# https://docs.github.com/en/actions/creating-actions/creating-a-composite-action
+name: Cache NPM
+description: Composite action (cache NPM)
+
+runs:
+  using: composite
+  steps:
+    # https://github.com/actions/cache/blob/master/examples.md#node---npm
+    # https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter
+    - name: Get NPM cache directory
+      run: echo "NPM_CACHE_DIRECTORY=$(npm config get cache)" >> ${{ github.env }} # use "github.env" instead of "github.output"; if use "github.output", "Warning: Input required and not supplied: path" is displayed on post-process
+      shell: pwsh # use PowerShell; Bash doesn't work on Windows because the value of "github.env" is like "D:\a\_temp\_runner_file_commands\set_env_XXX".
+
+    - name: Get Node.js version
+      run: echo "NODEJS_VERSION=$(node -v)" >> ${{ github.env }}
+      shell: pwsh
+
+    - name: Cache NPM modules
+      uses: actions/cache@v3
+      with:
+        path: ${{ env.NPM_CACHE_DIRECTORY }}
+        key: npm-${{ runner.os }}-${{ runner.arch }}-${{ env.NODEJS_VERSION }}-${{ hashFiles('package-lock.json') }}
+        restore-keys: |
+          npm-${{ runner.os }}-${{ runner.arch }}-${{ env.NODEJS_VERSION }}-
+          npm-${{ runner.os }}-${{ runner.arch }}

.github/workflows/build.yml

@@ -12,25 +12,31 @@ jobs:
     strategy:
       matrix:
         os:
-        - Windows-2019
-        - macOS-10.15
-        - Ubuntu-18.04
-        - Ubuntu-20.04
+        - windows-2019
+        - windows-2022
+        - macos-11
+        - macos-12
+        - ubuntu-20.04
+        - ubuntu-22.04
         nodejs:
-        - 12
+        - 20
       fail-fast: false
     steps:
     - name: Turn off auto-crlf
       run: git config --global core.autocrlf false
     - name: Checkout source codes
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
     - name: Install Node.js
-      uses: actions/setup-node@v1
+      uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.nodejs }}
+    - name: Cache NPM
+      uses: ./.github/actions/cache-npm
     - name: Install dependencies
       run: npm ci
     - name: Build
       run: npm run build
+    - name: Exit if differ (forgot to commit dist dir?)
+      run: git diff --exit-code --quiet
     - name: Verify
       run: npm run verify