Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade prefect 1.* to 2.13 #374

Merged
merged 38 commits into from
Nov 30, 2023
Merged

Upgrade prefect 1.* to 2.13 #374

merged 38 commits into from
Nov 30, 2023

Conversation

annshress
Copy link
Collaborator

@annshress annshress commented Nov 13, 2023 •
edited
Loading

Upgrade the prefect version from legacy (1.x) to current (2.x)

Changes

  • Refactors the flows and flow tests

Breaking:

  • Flows are invoked from api using deployment ids, and the apis follow REST rather than GraphQL

This PR doesn't introduce any:

  • Binary files
  • Temporary files, auto-generated files
  • Secret keys
  • Local debugging print statements
  • Unwanted comments (e.g: # Gets user from environment for code os.environ['user'] )

This PR contains valid:

  • tests

@annshress annshress requested a review from philipmac November 13, 2023 16:55
philipmac
philipmac reviewed Nov 20, 2023
View reviewed changes
em_workflows/czi/flow.py Outdated Show resolved Hide resolved
annshress referenced this pull request Nov 20, 2023
@annshress
Add copy workdir logs to assets
f288b16
@annshress annshress changed the base branch from main to dev November 27, 2023 17:55
@philipmac philipmac mentioned this pull request Nov 28, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2023 •
edited
Loading

Coverage report

Note

Coverage evolution disabled because this PR targets a different branch
than the default branch, for which coverage data is not available.

The coverage rate is 72.06%.
The branch rate is 56%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@annshress annshress self-assigned this Nov 30, 2023
@annshress
Convert flow name dm conversion to Small 2d
ca52c88 
As the input files are not only limited to dm3/4 but tiff, png, and mrc.
@annshress annshress merged commit bfcfd36 into dev Nov 30, 2023
1 check passed
@annshress annshress deleted the feature/prefect2 branch November 30, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipmac philipmac philipmac left review comments

Assignees

@annshress annshress

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annshress @philipmac