-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Upgrade prefect 1.* to 2.13 #353
Conversation
9d649fd
to
68a2744
Compare
em_workflows/brt/flow.py
Outdated
log_prints=True, | ||
task_runner=BRTConfig.SLURM_EXECUTOR, | ||
on_completion=utils.notify_api_completion, | ||
# on_failure=utils.notify_api_completion, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems strange they don't have a helper like on_start
- (we could put the call into the API there)
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)em_workflows/config.py
em_workflows/czi/flow.py
em_workflows/dm_conversion/flow.py
em_workflows/file_path.py
em_workflows/utils/utils.py
|
43dbed7
to
07bb85a
Compare
fb4863b
to
2eb7eab
Compare
2eb7eab
to
db9dca6
Compare
13df3fb
to
40024c7
Compare
40024c7
to
31cfda7
Compare
Upgrade the prefect version from legacy (1.x) to current (2.x)
Changes
Breaking:
deployment id
s, and the apis follow REST rather than GraphQLThis PR doesn't introduce any:
print
statementsos.environ['user']
)This PR contains valid: