Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Upgrade prefect 1.* to 2.13 #353

Closed
wants to merge 19 commits into from
Closed

Conversation

annshress
Copy link
Collaborator

@annshress annshress commented Oct 12, 2023

Upgrade the prefect version from legacy (1.x) to current (2.x)

Changes

  • Refactors the flows and flow tests

Breaking:

  • Flows are invoked from api using deployment ids, and the apis follow REST rather than GraphQL

This PR doesn't introduce any:

  • Binary files
  • Temporary files, auto-generated files
  • Secret keys
  • Local debugging print statements
  • Unwanted comments (e.g: # Gets user from environment for code os.environ['user'] )

This PR contains valid:

  • tests

@niaid niaid deleted a comment from github-actions bot Oct 12, 2023
log_prints=True,
task_runner=BRTConfig.SLURM_EXECUTOR,
on_completion=utils.notify_api_completion,
# on_failure=utils.notify_api_completion,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems strange they don't have a helper like on_start - (we could put the call into the API there)

@niaid niaid deleted a comment from github-actions bot Oct 13, 2023
@github-actions
Copy link

github-actions bot commented Oct 13, 2023

Coverage report

The coverage rate went from 63.93% to 64.03% ⬆️
The branch rate is 46%.

59.37% of new lines are covered.

Diff Coverage details (click to unfold)

em_workflows/config.py

75% of new lines are covered (79.59% of the complete file).
Missing lines: 41, 42

em_workflows/czi/flow.py

75% of new lines are covered (23.85% of the complete file).
Missing lines: 158

em_workflows/dm_conversion/flow.py

70% of new lines are covered (89.36% of the complete file).
Missing lines: 68, 136, 175

em_workflows/file_path.py

70% of new lines are covered (81.34% of the complete file).
Missing lines: 118, 261, 266

em_workflows/utils/utils.py

53.12% of new lines are covered (59.63% of the complete file).
Missing lines: 283, 354, 413, 423, 439, 449, 450, 451, 452, 456, 459, 460, 461, 462, 463, 464, 465, 524, 528, 531, 532, 533, 534, 535, 536, 537, 538, 615, 629, 631

@annshress annshress changed the title Feature/prefect2 Feature: Upgrade prefect 1.* to 2.13 Oct 16, 2023
@annshress annshress force-pushed the feature/prefect2 branch 6 times, most recently from fb4863b to 2eb7eab Compare November 2, 2023 20:39
@annshress annshress marked this pull request as ready for review November 2, 2023 20:43
@annshress annshress force-pushed the feature/prefect2 branch 2 times, most recently from 13df3fb to 40024c7 Compare November 6, 2023 17:34
@annshress annshress marked this pull request as draft November 9, 2023 13:49
@annshress annshress closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants