Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LastUpdated support for Tags API #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MileaRobertStefan
Copy link

@MileaRobertStefan MileaRobertStefan commented Oct 6, 2023

TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.

What does this Pull Request accomplish?

Updates the swagger.

Why should this Pull Request be merged?

We updated the API.

What testing has been done?

This are what the routes return.

Copy link
Contributor

@gergo-papp gergo-papp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea how I ended up here, but had to comment 🤣

@@ -1663,6 +1663,7 @@ definitions:
path: foo
type: DOUBLE
keywords: [fooKeyword, barKeyword]
last_updated: 1696579890
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be camelCase and ISO-formatted?

Suggested change
last_updated: 1696579890
lastUpdated: '2023-10-06T11:45:08Z'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants