-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Required indicator on radio-group, select, combobox, and text-area #2496
Draft
mollykreis
wants to merge
16
commits into
main
Choose a base branch
from
required-indicator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@msmithNI - will you buddy this PR for me? |
mollykreis
changed the title
Required indicator
Required indicator on radio-group, select, combobox, and text-area
Dec 12, 2024
msmithNI
approved these changes
Dec 12, 2024
Looks like nodejs/node#56127 highlights the build issue we have here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Add
required-visible
attributes to the radio-group, select, combobox, and text-area components as part of #2100.There is still a need to add this attribute to the text-field and number-field. That will be done once the templates for those components have been forked (#2495).
👩💻 Implementation
Within the
patterns
directory, I created a mixin that can be used on elements that should have arequiredVisible
property andrequired-visible
attribute. Additionally, shared styling was added for therequiredVisible
state and a function was created to generate the template for an element's label. This is a function rather than a constant template because each element already had an existing label structure that I didn't want to change as part of this PR.The template of each element included in this PR was also updated to set
aria-required
based on the value ofrequiredVisible
.I also updated the styling of icons to make the
svg
display: block
because this solved a problem I encountered when shrinking the asterisk icon down to 5x5.🧪 Testing
✅ Checklist