Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select - no longer update value while navigating dropdown #2029

Merged
merged 47 commits into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from 46 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
29ec3cd
Change Select to not update value as you navigate options in dropdown.
atmgrifter00 Apr 22, 2024
cd06c39
Change files
atmgrifter00 Apr 22, 2024
26700f0
Slight renaming.
atmgrifter00 Apr 22, 2024
2984113
Minor change with test.
atmgrifter00 Apr 22, 2024
6b089fa
Remove fit.
atmgrifter00 Apr 22, 2024
2a65f92
Linting
atmgrifter00 Apr 22, 2024
652642f
prettier
atmgrifter00 Apr 22, 2024
a4709e3
Fix issue with Listbox typeahead changing selectedIndex.
atmgrifter00 Apr 23, 2024
11c2611
Linting.
atmgrifter00 Apr 23, 2024
25b9213
Revert previous solution for dealing with typeahead, and instead prov…
atmgrifter00 Apr 24, 2024
2a1fd87
Test doc update.
atmgrifter00 Apr 24, 2024
23b201e
Merge branch 'main' into select-no-value-update-refactor
atmgrifter00 Apr 24, 2024
8f69548
Code clean up.
atmgrifter00 Apr 24, 2024
62a714e
Merge branch 'select-no-value-update-refactor' of https://github.com/…
atmgrifter00 Apr 24, 2024
08e2f7c
Linting.
atmgrifter00 Apr 24, 2024
d769813
Merge branch 'main' into select-no-value-update-refactor
atmgrifter00 Apr 24, 2024
429665b
Merge branch 'main' into select-no-value-update-refactor
atmgrifter00 Apr 24, 2024
2cde4ea
Handle PR feedback.
atmgrifter00 Apr 24, 2024
b162f8b
Code clean up.
atmgrifter00 Apr 25, 2024
d74b6ee
Reverting a change.
atmgrifter00 Apr 25, 2024
9f6c6d6
Fixes and tests.
atmgrifter00 Apr 25, 2024
d9626e4
Fix tests.
atmgrifter00 Apr 25, 2024
f096b79
Fix matrix tests.
atmgrifter00 Apr 25, 2024
016026f
Fix styling for other dropdown controls.
atmgrifter00 Apr 25, 2024
3edd7f5
Update packages/nimble-components/src/select/testing/select.pageobjec…
atmgrifter00 Apr 26, 2024
3a71144
Handle PR feedback. Fixes/tests.
atmgrifter00 Apr 26, 2024
270f313
Merge branch 'select-no-value-update-refactor' of https://github.com/…
atmgrifter00 Apr 26, 2024
dc3329f
Slight change with test.
atmgrifter00 Apr 26, 2024
98160ff
Revert change
atmgrifter00 Apr 26, 2024
04f0916
Style fix.
atmgrifter00 Apr 26, 2024
a9dc531
Simplify CSS.
atmgrifter00 Apr 26, 2024
03cdc29
Merge branch 'main' into select-no-value-update-refactor
atmgrifter00 Apr 29, 2024
042d2b0
Fix build.
atmgrifter00 Apr 29, 2024
7d4ba9a
Handle PR feedback.
atmgrifter00 Apr 29, 2024
6f22ec7
Handle PR feedback.
atmgrifter00 Apr 30, 2024
68f22d1
Merge branch 'main' into select-no-value-update-refactor
atmgrifter00 Apr 30, 2024
866c6de
Fix test failure.
atmgrifter00 Apr 30, 2024
0ccd719
Merge branch 'select-no-value-update-refactor' of https://github.com/…
atmgrifter00 Apr 30, 2024
5f96ab1
Merge branch 'main' into select-no-value-update-refactor
atmgrifter00 May 6, 2024
7b4c601
Update packages/nimble-components/src/select/styles.ts
atmgrifter00 May 6, 2024
5c79b29
Merge branch 'select-no-value-update-refactor' of https://github.com/…
atmgrifter00 May 6, 2024
7087522
Handle PR feedback
atmgrifter00 May 6, 2024
061d9cc
Merge branch 'main' into select-no-value-update-refactor
atmgrifter00 May 6, 2024
0d0bb13
Rename page object method.
atmgrifter00 May 7, 2024
9b69c68
Merge branch 'select-no-value-update-refactor' of https://github.com/…
atmgrifter00 May 7, 2024
571973f
Merge branch 'main' into select-no-value-update-refactor
atmgrifter00 May 7, 2024
dd79cd5
Update packages/storybook/src/nimble/select/select-matrix.stories.ts
rajsite May 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
atmgrifter00 marked this conversation as resolved.
Show resolved Hide resolved
atmgrifter00 marked this conversation as resolved.
Show resolved Hide resolved
atmgrifter00 marked this conversation as resolved.
Show resolved Hide resolved
"type": "patch",
"comment": "Change Select to not update value as you navigate options in dropdown.",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
11 changes: 11 additions & 0 deletions packages/nimble-components/src/list-option/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,17 @@ export class ListOption extends FoundationListboxOption {
@attr({ attribute: 'visually-hidden', mode: 'boolean' })
public visuallyHidden = false;

/**
* @internal
* This attribute is used to control the visual selected state of an option. This
* is handled independently of the public 'selected' attribute, as 'selected' is
* representative of the current value of the container control. However, while
* a dropdown is open users can navigate through the options (requiring visual
* updates) without changing the value of the container control.
*/
@attr({ attribute: 'active-option', mode: 'boolean' })
public activeOption = false;

/** @internal */
@observable
public hasOverflow = false;
Expand Down
Loading
Loading