Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a new Experimental Prerendering module #1955

Merged
merged 73 commits into from
Apr 4, 2024

Conversation

munteannatan
Copy link
Contributor

@munteannatan munteannatan commented Mar 21, 2024

Pull Request

🤨 Rationale

Created a new experimental prerendering module.

The previous prerendering oversaw calculating the fillstyle of each die and it's label.
We want to move these expensive operations to the web worker, and to make them faster.

👩‍💻 Implementation

I removed the code which prepared the dies for rendering.
I created a domain splitter for linear color scales. this will reduce the number of colors displayed but will increase the performance because we are no longer finding interpolations for each individual value in the whole domain.

Open Issues:

  • given the problems with arquero, should we implement in-house highlight or leave it unimplemented until the issue gets fixed?

🧪 Testing

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@atmgrifter00 atmgrifter00 marked this pull request as ready for review April 2, 2024 13:37
@jattasNI
Copy link
Contributor

jattasNI commented Apr 2, 2024

I'll be OOO this week, feel free to complete without my review.

@munteannatan munteannatan requested a review from rajsite April 3, 2024 13:30
@rajsite
Copy link
Member

rajsite commented Apr 3, 2024

@munteannatan you don't need to wait for Jesse. I don't know about the remaining owners @DStavilaNI @zszilagy

@munteannatan munteannatan merged commit b6e22fe into main Apr 4, 2024
11 checks passed
@munteannatan munteannatan deleted the users/munteannatan/experimental-prerendering branch April 4, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants