-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a new Experimental Prerendering module #1955
Merged
munteannatan
merged 73 commits into
main
from
users/munteannatan/experimental-prerendering
Apr 4, 2024
Merged
Created a new Experimental Prerendering module #1955
munteannatan
merged 73 commits into
main
from
users/munteannatan/experimental-prerendering
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eannatan/experimental-computations
…eannatan/experimental-computations
…eannatan/experimental-computations
packages/nimble-components/src/wafer-map/modules/experimental/prerendering.ts
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/tests/experimantal-prerendering.spec.ts
Outdated
Show resolved
Hide resolved
atmgrifter00
approved these changes
Apr 2, 2024
atmgrifter00
requested review from
rajsite,
jattasNI,
DStavilaNI and
zszilagy
as code owners
April 2, 2024 13:37
I'll be OOO this week, feel free to complete without my review. |
rajsite
reviewed
Apr 2, 2024
packages/nimble-components/src/wafer-map/modules/hover-handler.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Apr 2, 2024
packages/nimble-components/src/wafer-map/modules/prerendering.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/modules/prerendering.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/wafer-map/modules/prerendering.ts
Outdated
Show resolved
Hide resolved
rajsite
approved these changes
Apr 3, 2024
@munteannatan you don't need to wait for Jesse. I don't know about the remaining owners @DStavilaNI @zszilagy |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Created a new experimental prerendering module.
The previous prerendering oversaw calculating the
fillstyle
of each die and it's label.We want to move these expensive operations to the web worker, and to make them faster.
👩💻 Implementation
I removed the code which prepared the dies for rendering.
I created a domain splitter for linear color scales. this will reduce the number of colors displayed but will increase the performance because we are no longer finding interpolations for each individual value in the whole domain.
Open Issues:
🧪 Testing
✅ Checklist