Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR for Nimble vs Spright #1856

Merged
merged 12 commits into from
Mar 29, 2024
Merged

ADR for Nimble vs Spright #1856

merged 12 commits into from
Mar 29, 2024

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented Feb 22, 2024

Pull Request

🀨 Rationale

Need to define the expectations for components that go in Nimble vs Spright vs ...
Fixes: #1850

πŸ‘©β€πŸ’» Implementation

Wrote ADR

πŸ§ͺ Testing

N/A

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc m-akinc requested a review from jattasNI February 22, 2024 01:10
Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial thoughts, will probably have more as I keep pondering

docs/nimble-spright-requirements-adr.md Outdated Show resolved Hide resolved
docs/nimble-spright-requirements-adr.md Outdated Show resolved Hide resolved
docs/nimble-spright-requirements-adr.md Show resolved Hide resolved
docs/nimble-spright-requirements-adr.md Outdated Show resolved Hide resolved
docs/nimble-spright-requirements-adr.md Outdated Show resolved Hide resolved
docs/nimble-spright-requirements-adr.md Outdated Show resolved Hide resolved
@m-akinc m-akinc requested review from rajsite and jattasNI February 29, 2024 23:06
@m-akinc m-akinc marked this pull request as ready for review March 1, 2024 21:42
Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor suggestions I had from my initial scan of the document which I forgot to hit submit on. The changes we discussed offline are more important.

docs/nimble-spright-requirements-adr.md Outdated Show resolved Hide resolved
docs/nimble-spright-requirements-adr.md Outdated Show resolved Hide resolved
@m-akinc m-akinc requested a review from jattasNI March 26, 2024 14:11
@rajsite rajsite requested a review from jattasNI March 28, 2024 22:48
@m-akinc m-akinc merged commit f71ba85 into main Mar 29, 2024
13 checks passed
@m-akinc m-akinc deleted the users/makinc/spright-adr branch March 29, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create ADR characterizing Nimble, Spright, and incubating components
3 participants