Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook 8 Upgrade #1816

Merged
merged 37 commits into from
Mar 27, 2024
Merged

Storybook 8 Upgrade #1816

merged 37 commits into from
Mar 27, 2024

Conversation

fredvisser
Copy link
Contributor

@fredvisser fredvisser commented Feb 9, 2024 •
edited
Loading

Pull Request

🤨 Rationale

Update to the latest Storybook version.

https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md#800

👩‍💻 Implementation

Followed Storybook migration guide

🧪 Testing

Manual review of Storybook documentation

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

fredvisser and others added 25 commits February 9, 2024 15:58
@fredvisser
Initial SB 8 upgrade
e0701b0
@fredvisser
Merge branch 'main' into user/fvisser/storybook-8-beta-test
8131547
@fredvisser
Change files
bd45267
@fredvisser
beta 2
72b2837
@fredvisser
add missing types
aa7d8d3
@fredvisser
chromatic local compare addon
decbe65
@m-akinc
Configure webpack minification to avoid error in --test build
41e15fc
@m-akinc
Fix lint issues
aed7cf7
@fredvisser
Merge branch 'user/fvisser/storybook-8-beta-test' of github.com:ni/ni…
315dde2 
…mble into user/fvisser/storybook-8-beta-test
@fredvisser
remove test flag
5608fea
@fredvisser
updated package-lock
7ab6fdc
@fredvisser
fix for prettier
6a7fe1b
@fredvisser
Merge branch 'main' into user/fvisser/storybook-8-beta-test
beee7aa
@fredvisser
update package-lock
4d66620
@fredvisser
Merge branch 'main' into user/fvisser/storybook-8-beta-test
edba305
@fredvisser
pin beachball to patch version
6cd90eb
@fredvisser
fix build
5e72a40
@fredvisser
beta 4
f4c3587
@fredvisser
Merge branch 'main' into user/fvisser/storybook-8-beta-test
bd34937
@fredvisser
fix build
fa5f835
@fredvisser
Upgrade Chromatic Github Action
7eccd74
@fredvisser
update to rc.0
b7ce0d9
@fredvisser
Merge branch 'main' into user/fvisser/storybook-8-beta-test
9e59868
@fredvisser
migrate to new addon manager package
ef34718
@fredvisser
Merge branch 'main' into user/fvisser/storybook-8-beta-test
5780109
@fredvisser fredvisser marked this pull request as ready for review March 12, 2024 22:15
rajsite
rajsite reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The built storybook is so snappy! 🏎

package.json Outdated Show resolved Hide resolved
packages/nimble-components/package.json Outdated Show resolved Hide resolved
@fredvisser fredvisser changed the title Storybook 8 Beta Upgrade Storybook 8 Upgrade Mar 25, 2024
@fredvisser fredvisser requested review from rajsite and jattasNI March 26, 2024 04:11
rajsite
rajsite approved these changes Mar 26, 2024
View reviewed changes
packages/nimble-components/.storybook/main.js Outdated Show resolved Hide resolved
@rajsite rajsite merged commit fec2d9c into main Mar 27, 2024
11 checks passed
@rajsite rajsite deleted the user/fvisser/storybook-8-beta-test branch March 27, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajsite rajsite rajsite approved these changes

@jattasNI jattasNI Awaiting requested review from jattasNI jattasNI is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fredvisser @rajsite @jattasNI @m-akinc