Skip to content

Commit

Permalink
Fast foundation update (#2450)
Browse files Browse the repository at this point in the history
# Pull Request

## 🤨 Rationale

Update FAST versions to include the following fixes:
- microsoft/fast#7022
- microsoft/fast#6960

And handle the following NI issues:
- Fixes #1661
- https://ni.visualstudio.com/DevCentral/_workitems/edit/2843309

## 👩‍💻 Implementation

Updates the Fast Foundation version. A test performance regression was
found in all browsers but particularly in Firefox, however [after
investigation by @m-akinc](#2456) it
was found to be an acceptable change. Fixes
#2456

## 🧪 Testing

Extensive testing done in #2456

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Mert Akinc <[email protected]>
  • Loading branch information
rajsite and m-akinc authored Nov 5, 2024
1 parent 6b1869f commit fa9b9ce
Show file tree
Hide file tree
Showing 7 changed files with 41 additions and 26 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update fast versions",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update fast versions",
"packageName": "@ni/spright-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
38 changes: 19 additions & 19 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/nimble-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@
"homepage": "https://github.com/ni/nimble#readme",
"dependencies": {
"@microsoft/fast-colors": "^5.3.1",
"@microsoft/fast-element": "1.13.0",
"@microsoft/fast-foundation": "2.49.6",
"@microsoft/fast-element": "^1.14.0",
"@microsoft/fast-foundation": "^2.50.0",
"@microsoft/fast-web-utilities": "^6.0.0",
"@ni/nimble-tokens": "^8.4.0",
"@tanstack/table-core": "^8.19.3",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
console.error = (data: any): void => fail(data);
// eslint-disable-next-line no-console, @typescript-eslint/no-explicit-any
console.warn = (data: any): void => fail(data);
jasmine.DEFAULT_TIMEOUT_INTERVAL = 10000;
4 changes: 2 additions & 2 deletions packages/spright-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@
},
"homepage": "https://github.com/ni/nimble#readme",
"dependencies": {
"@microsoft/fast-element": "1.13.0",
"@microsoft/fast-foundation": "2.49.6",
"@microsoft/fast-element": "^1.14.0",
"@microsoft/fast-foundation": "^2.50.0",
"@ni/nimble-components": "^32.6.0",
"tslib": "^2.2.0"
},
Expand Down
6 changes: 3 additions & 3 deletions packages/storybook/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
},
"devDependencies": {
"@chromatic-com/storybook": "^2.0.2",
"@microsoft/fast-element": "1.13.0",
"@microsoft/fast-foundation": "2.49.6",
"@microsoft/fast-react-wrapper": "^0.3.22",
"@microsoft/fast-element": "^1.14.0",
"@microsoft/fast-foundation": "^2.50.0",
"@microsoft/fast-react-wrapper": "^0.3.25",
"@microsoft/fast-web-utilities": "^6.0.0",
"@ni/nimble-components": "*",
"@ni/spright-components": "*",
Expand Down

0 comments on commit fa9b9ce

Please sign in to comment.