Merge branch 'main' into column-placeholder-hld

ni · Mar 7, 2024 · e9cebdd · e9cebdd
2 parents 4d8e117 + 2c78284
commit e9cebdd
Show file tree

Hide file tree

Showing 67 changed files with 6,364 additions and 5,288 deletions.
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
@@ -1,5 +1,5 @@
 ---
-name: 🐛 Bug report
+name: 🐛 Bug Report
 about: Create a report to help us improve
 title: ''
 labels: 'bug,triage'

diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md
@@ -1,5 +1,5 @@
 ---
-name: 🙋 Feature request
+name: 🙋 Feature Request
 about: Suggest an idea for this project
 title: ''
 labels: 'enhancement,triage'
@@ -11,6 +11,8 @@ Thanks for filing an issue 😄! Before you submit, please read the following:
 Search open/closed issues before submitting. Someone may have requested the same feature before.
 -->
 
+# 🙋 Feature Request
+
 ## 😯 Problem to Solve
 
 <!--- Provide a clear and concise description of why this feature is wanted or what problem it solves. -->

diff --git a/.github/ISSUE_TEMPLATE/ixd_user_story.md → ...UE_TEMPLATE/interaction_design_request.md b/.github/ISSUE_TEMPLATE/ixd_user_story.md → ...UE_TEMPLATE/interaction_design_request.md
@@ -1,12 +1,14 @@
 ---
-name: 🧑‍💼 Interaction Design (IxD) User story
+name:  👈 Interaction Design Request
 about: (PO ONLY) A small chunk of work to be done by an Interaction Designer
 title: 'nimble-{name} interaction design request'
-labels: 'IxD,triage'
+labels: 'interaction design,triage'
 ---
 
 <!-- Ensure the title can be understood without the parent item's context, e.g. "nimble-datepicker interaction design request" rather than just "Interaction Design" -->
 
+# 👈 Interaction Design Request
+
 ## 📌 Request Background
 
 <!-- A short description of the request and requester. E.g. Who is the client and how do they expect to use the component? -->
@@ -33,4 +35,4 @@ labels: 'IxD,triage'
 
 - [ ] Interaction Design Spec submitted (link)
 - [ ] Interaction Design Spec reviewed by design team
-- [ ] Interaction Design Spec reviewed by dev team
+- [ ] Interaction Design Spec reviewed by dev team
diff --git a/.github/ISSUE_TEMPLATE/new_component.md b/.github/ISSUE_TEMPLATE/new_component.md
@@ -1,10 +1,12 @@
 ---
-name: 💡 New component
+name: 💡 New Component
 about: (DEV TEAM ONLY) New Nimble component
 title: 'nimble-{name} Component'
-labels: 'enhancement'
+labels: 'new component,enhancement'
 ---
 
+# 💡 New Component
+
 ## 😯 Problem to Solve
 
 <!-- List any clients/contacts that specifically need this component, or note that the component just adds general utility. -->
@@ -18,8 +20,7 @@ labels: 'enhancement'
 
 ## 📋 Tasks
 
-<!-- Refer to [CONTR
-IBUTING](https://github.com/ni/nimble/blob/main/packages/nimble-components/CONTRIBUTING.md) for details -->
+<!-- Refer to https://github.com/ni/nimble/blob/main/packages/nimble-components/CONTRIBUTING.md for details -->
 
 - [ ] nimble-{name} interaction design issue
 - [ ] nimble-{name} interaction design spec

diff --git a/.github/ISSUE_TEMPLATE/tech_debt.md b/.github/ISSUE_TEMPLATE/tech_debt.md
@@ -1,7 +1,8 @@
 ---
-name: 🧹 Tech debt
+name: 🧹 Tech Debt
 about: (DEV TEAM ONLY) Non-user-visible improvement to code or development process
 title: ''
 labels: 'tech debt,triage'
 ---
-## 🧹 Tech Debt
+
+# 🧹 Tech Debt
diff --git a/.github/ISSUE_TEMPLATE/user_story.md b/.github/ISSUE_TEMPLATE/user_story.md
@@ -6,4 +6,4 @@ title: '(Fully descriptive title)'
 
 <!-- Ensure the title can be understood without the parent item's context, e.g. "nimble-button Angular wrapper" rather than just "Angular wrapper" -->
 
-## 📌 User Story
+# 📌 User Story
diff --git a/...SSUE_TEMPLATE/visual_design_user_story.md → ...b/ISSUE_TEMPLATE/visual_design_request.md b/...SSUE_TEMPLATE/visual_design_user_story.md → ...b/ISSUE_TEMPLATE/visual_design_request.md
@@ -1,12 +1,14 @@
 ---
-name: 🧑‍🎨 Visual Design (ViD) User story
+name: 🎨 Visual Design Request
 about: (DEV TEAM ONLY) A small chunk of work to be done by Visual Designer
 title: 'nimble-{name} visual design request'
-labels: 'ViD,triage'
+labels: 'visual design,triage'
 ---
 
 <!-- Ensure the title can be understood without the parent item's context, e.g. "nimble-datepicker Visual Design" rather than just "Visual Design" -->
 
+# 🎨 Visual Design Request
+
 ## 📌 Request Background
 
 <!-- A short description of the request and requester. E.g. Who is the client and how do they expect to use the component? -->
@@ -33,4 +35,4 @@ labels: 'ViD,triage'
 
 - [ ] Visual Design Spec submitted (link)
 - [ ] Visual Design Spec reviewed by design team
-- [ ] Visual Design Spec reviewed by dev team
+- [ ] Visual Design Spec reviewed by dev team
diff --git a/.github/renovate.json b/.github/renovate.json
@@ -3,50 +3,49 @@
   "extends": [
     "config:base"
   ],
-  "enabledManagers": ["npm", "nuget"],
+  "enabledManagers": ["npm", "nuget", "github-actions"],
   "rebaseWhen": "conflicted",
   "schedule": [
     "monthly"
   ],
   "packageRules": [
     {
-      "matchManagers": ["npm"],
+      "matchManagers": ["npm", "nuget", "github-actions"],
       "enabled": false
     },
     {
-      "groupName": "npm dependencies",
+      "groupName": "npm dependencies lock update only",
       "matchManagers": ["npm"],
-      "rangeStrategy": "update-lockfile",
-      "matchDepTypes": ["dependencies"],
-      "matchPackagePatterns":[
-        "^@microsoft/fast",
-        "^@tanstack/",
-        "^@tiptap/",
-        "@types/markdown-it",
-        "comlink",
-        "d3-",
-        "prosemirror-"
-      ],
+      "rangeStrategy": "in-range-only",
+      "matchDepTypes": ["dependencies", "devDependencies"],
       "enabled": true
     },
     {
-      "groupName": "npm dev dependencies",
+      "groupName": "npm dependencies update to latest",
       "matchManagers": ["npm"],
       "rangeStrategy": "update-lockfile",
-      "matchDepTypes": ["devDependencies"],
-      "matchPackagePatterns":[
-        "^@ni/eslint-config",
-        "beachball",
-        "storybook"
+      "matchDepTypes": ["dependencies", "devDependencies"],
+      "excludePackagePatterns":[
+        "^@angular",
+        "@microsoft/fast-foundation",
+        "@microsoft/fast-react-wrapper",
+        "comlink",
+        "ng-packagr",
+        "playwright",
+        "remark-gfm",
+        "typescript",
+        "zone.js"
       ],
       "enabled": true
     },
     {
-      "groupName": "nuget bunit dependencies",
+      "groupName": "nuget dependencies",
       "matchManagers": ["nuget"],
-      "matchPackagePatterns":[
-        "^bunit"
-      ],
+      "enabled": true
+    },
+    {
+      "groupName": "github actions dependencies",
+      "matchManagers": ["github-actions"],
       "enabled": true
     }
   ]

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -26,35 +26,32 @@ jobs:
   build:
     runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         if: env.HAS_GITHUBPAGESDEPLOYTOKEN == 'true'
         with:
-          # Required for beachball changelog detection
+          # Required for chromatic change detection
           fetch-depth: 0
           # Must checkout with a token that can push to protected branches for beachball
           # Cannot rely on GITHUB_TOKEN with workflow contents permission
           # See: https://github.com/orgs/community/discussions/40971
           token: ${{ secrets.GITHUBPAGESDEPLOYTOKEN }}
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         if: env.HAS_GITHUBPAGESDEPLOYTOKEN == 'false'
         with:
-          # Required for beachball changelog detection
+          # Required for chromatic change detection
           fetch-depth: 0
 
       # Install dependencies
-      - uses: actions/setup-dotnet@v3
+      - uses: actions/setup-dotnet@v4
         with:
           global-json-file: packages/nimble-blazor/global.json
       - run: dotnet --info
         working-directory: packages/nimble-blazor/
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
           node-version: '20'
           registry-url: 'https://registry.npmjs.org'
           cache: 'npm'
-      # Specify npm version
-      # See: https://github.com/actions/setup-node/issues/529
-      - run: npm i -g npm@9
       - run: npm ci
 
       # print a log of outdated npm dependencies
@@ -71,26 +68,22 @@ jobs:
 
       # Pack
       - run: npm run pack
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: packages
           path: |
             packages/**/*.tgz
             packages/**/*.nupkg
             angular-workspace/**/*.tgz
           if-no-files-found: error
-      # The actions/upload-pages-artifact@v1 results in unexpected warning messages, workaround for:
-      # https://github.com/actions/upload-pages-artifact/issues/45
-      - name: Pages file permission workaround
-        run: chmod -c -R +rX packages/site/dist
-      - uses: actions/upload-pages-artifact@v1
+      - uses: actions/upload-pages-artifact@v3
         with:
           path: 'packages/site/dist'
 
       # Publish to Chromatic (from any push)
       - name: Publish to Chromatic
         if: env.HAS_CHROMATIC_PROJECT_TOKEN == 'true' && github.event_name == 'push'
-        uses: chromaui/action@v1
+        uses: chromaui/action@v11
         with:
           projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
           onlyChanged: "!startsWith(github.ref, 'refs/heads/main')" # Use TurboSnap for PR builds
@@ -117,7 +110,8 @@ jobs:
           LHCI_GITHUB_APP_TOKEN: ${{ secrets.LHCI_GITHUB_APP_TOKEN }}
 
       # Check Changelog
-      - run: npm run check
+      - if: github.repository_owner == 'ni'
+        run: npm run check
 
       - name: Validate no changes to tracked files
         run: |
@@ -143,7 +137,7 @@ jobs:
 
   pages:
     needs: build
-    if: startsWith(github.ref, 'refs/heads/main')
+    if: github.repository_owner == 'ni' && startsWith(github.ref, 'refs/heads/main')
     runs-on: ubuntu-22.04
     permissions:
       pages: write # to deploy to Pages
@@ -154,4 +148,4 @@ jobs:
     steps:
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@v1
+        uses: actions/deploy-pages@v4
diff --git a/angular-workspace/package.json b/angular-workspace/package.json
@@ -48,18 +48,18 @@
     "@ni/jasmine-parameterized": "*",
     "@ni/nimble-tokens": "*",
     "@rollup/plugin-node-resolve": "^15.0.1",
-    "@types/jasmine": "^4.3.1",
-    "@types/node": "^18.11.18",
-    "eslint-plugin-jsdoc": "^46.8.2",
-    "jasmine-core": "^4.5.0",
+    "@types/jasmine": "^5.1.4",
+    "@types/node": "^20.11.24",
+    "eslint-plugin-jsdoc": "^48.2.0",
+    "jasmine-core": "^5.1.2",
     "karma": "^6.3.0",
     "karma-chrome-launcher": "^3.1.0",
     "karma-coverage": "^2.0.3",
     "karma-jasmine": "^5.1.0",
     "karma-jasmine-html-reporter": "^2.0.0",
     "ng-packagr": "^15.2.2",
     "playwright": "1.40.0",
-    "rollup": "^3.10.1",
+    "rollup": "^4.12.0",
     "typescript": "~4.8.2"
   }
 }
diff --git a/angular-workspace/projects/ni/nimble-angular/CHANGELOG.json b/angular-workspace/projects/ni/nimble-angular/CHANGELOG.json
@@ -1,6 +1,51 @@
 {
   "name": "@ni/nimble-angular",
   "entries": [
+    {
+      "date": "Wed, 06 Mar 2024 17:56:10 GMT",
+      "version": "20.2.19",
+      "tag": "@ni/nimble-angular_v20.2.19",
+      "comments": {
+        "patch": [
+          {
+            "author": "beachball",
+            "package": "@ni/nimble-angular",
+            "comment": "Bump @ni/nimble-components to v21.9.1",
+            "commit": "not available"
+          }
+        ]
+      }
+    },
+    {
+      "date": "Tue, 05 Mar 2024 22:27:12 GMT",
+      "version": "20.2.18",
+      "tag": "@ni/nimble-angular_v20.2.18",
+      "comments": {
+        "patch": [
+          {
+            "author": "beachball",
+            "package": "@ni/nimble-angular",
+            "comment": "Bump @ni/nimble-components to v21.9.0",
+            "commit": "not available"
+          }
+        ]
+      }
+    },
+    {
+      "date": "Mon, 04 Mar 2024 19:02:52 GMT",
+      "version": "20.2.17",
+      "tag": "@ni/nimble-angular_v20.2.17",
+      "comments": {
+        "patch": [
+          {
+            "author": "beachball",
+            "package": "@ni/nimble-angular",
+            "comment": "Bump @ni/nimble-components to v21.8.2",
+            "commit": "not available"
+          }
+        ]
+      }
+    },
     {
       "date": "Fri, 01 Mar 2024 23:02:58 GMT",
       "version": "20.2.16",

diff --git a/angular-workspace/projects/ni/nimble-angular/CHANGELOG.md b/angular-workspace/projects/ni/nimble-angular/CHANGELOG.md
@@ -1,9 +1,33 @@
 # Change Log - @ni/nimble-angular
 
-This log was last generated on Fri, 01 Mar 2024 23:02:58 GMT and should not be manually modified.
+This log was last generated on Wed, 06 Mar 2024 17:56:10 GMT and should not be manually modified.
 
 <!-- Start content -->
 
+## 20.2.19
+
+Wed, 06 Mar 2024 17:56:10 GMT
+
+### Patches
+
+- Bump @ni/nimble-components to v21.9.1
+
+## 20.2.18
+
+Tue, 05 Mar 2024 22:27:12 GMT
+
+### Patches
+
+- Bump @ni/nimble-components to v21.9.0
+
+## 20.2.17
+
+Mon, 04 Mar 2024 19:02:52 GMT
+
+### Patches
+
+- Bump @ni/nimble-components to v21.8.2
+
 ## 20.2.16
 
 Fri, 01 Mar 2024 23:02:58 GMT
Original file line number	Diff line number	Diff line change
Expand Up		@@ -6,4 +6,4 @@ title: '(Fully descriptive title)'

		<!-- Ensure the title can be understood without the parent item's context, e.g. "nimble-button Angular wrapper" rather than just "Angular wrapper" -->

		## 📌 User Story
		# 📌 User Story