More consistent tagging

ni · Mar 15, 2024 · c903633 · c903633
1 parent 01eac93
commit c903633
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 19 deletions.
diff --git a/packages/nimble-components/src/rich-text/editor/tests/rich-text-editor-mention.spec.ts b/packages/nimble-components/src/rich-text/editor/tests/rich-text-editor-mention.spec.ts
@@ -353,7 +353,7 @@ describe('RichTextEditorMention', () => {
                 expect(pageObject.getMentionButtonLabel(0)).toBe('');
             });
 
-            // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+            // WebKit skipped, see https://github.com/ni/nimble/issues/1938
             it('should have button title and text when `button-label` updated #SkipWebkit', async () => {
                 const { userMentionElement } = await appendUserMentionConfiguration(element);
                 userMentionElement.buttonLabel = 'at mention';
@@ -1033,7 +1033,7 @@ describe('RichTextEditor user mention via template', () => {
             expect(pageObject.getEditorFirstChildTextContent()).toBe('User @');
         });
 
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('should get `@` text without a preceding whitespace after a hard break, when button clicked #SkipWebkit', async () => {
             await pageObject.setEditorTextContent('User');
             await pageObject.pressShiftEnterKeysInEditor();
@@ -1047,7 +1047,7 @@ describe('RichTextEditor user mention via template', () => {
             expect(pageObject.getEditorFirstChildTextContent()).toBe('User@');
         });
 
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('should get `@` text with a single preceding whitespace after a hard break with a text, when button clicked #SkipWebkit', async () => {
             await pageObject.setEditorTextContent('User');
             await pageObject.pressShiftEnterKeysInEditor();
@@ -1357,7 +1357,7 @@ describe('RichTextEditorMentionListbox', () => {
             expect(pageObject.isMentionListboxOpened()).toBeFalse();
         });
 
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('setting `disabled` should close the mention popup #SkipWebkit', async () => {
             await appendUserMentionConfiguration(element, [
                 { key: 'user:1', displayName: 'username1' },

diff --git a/packages/nimble-components/src/rich-text/editor/tests/rich-text-editor.spec.ts b/packages/nimble-components/src/rich-text/editor/tests/rich-text-editor.spec.ts
@@ -216,7 +216,7 @@ describe('RichTextEditor', () => {
     describe('keyboard shortcuts should update the checked state of the buttons', () => {
         parameterizeSpec(formattingButtons, (spec, name, value) => {
             spec(
-                // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+                // WebKit skipped, see https://github.com/ni/nimble/issues/1938
                 `"${name}" button keyboard shortcut check #SkipWebkit`,
                 async () => {
                     expect(
@@ -263,7 +263,7 @@ describe('RichTextEditor', () => {
     });
 
     describe('rich text formatting options to its respective HTML elements', () => {
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('should have br tag name when pressing shift + enter #SkipWebkit', async () => {
             await pageObject.setEditorTextContent('Plain text 1');
             await pageObject.pressShiftEnterKeysInEditor();
@@ -281,7 +281,7 @@ describe('RichTextEditor', () => {
             expect(pageObject.getEditorLeafContents()).toEqual(['bold']);
         });
 
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('should have br tag name when pressing shift + Enter with bold content #SkipWebkit', async () => {
             await pageObject.toggleFooterButton(ToolbarButton.bold);
             await pageObject.setEditorTextContent('bold1');
@@ -304,7 +304,7 @@ describe('RichTextEditor', () => {
             expect(pageObject.getEditorLeafContents()).toEqual(['italics']);
         });
 
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('should have br tag name when pressing shift + Enter with Italics content #SkipWebkit', async () => {
             await pageObject.toggleFooterButton(ToolbarButton.italics);
             await pageObject.setEditorTextContent('italics1');
@@ -448,7 +448,7 @@ describe('RichTextEditor', () => {
             });
         });
 
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('should have br tag name when pressing shift + Enter with numbered list content #SkipWebkit', async () => {
             await pageObject.setEditorTextContent('numbered list1');
             await pageObject.toggleFooterButton(ToolbarButton.numberedList);
@@ -508,7 +508,7 @@ describe('RichTextEditor', () => {
             ).toBeTrue();
         });
 
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('should have br tag name when pressing shift + Enter with nested numbered lists content #SkipWebkit', async () => {
             await pageObject.setEditorTextContent('List');
             await pageObject.toggleFooterButton(ToolbarButton.numberedList);
@@ -598,7 +598,7 @@ describe('RichTextEditor', () => {
             expect(pageObject.getEditorLeafContents()).toEqual(['Bullet List']);
         });
 
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('should have br tag name when pressing shift + Enter with bulleted list content #SkipWebkit', async () => {
             await pageObject.setEditorTextContent('Bulleted List 1');
             await pageObject.toggleFooterButton(ToolbarButton.bulletList);
@@ -658,7 +658,7 @@ describe('RichTextEditor', () => {
             ).toBeTrue();
         });
 
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('should have br tag name when pressing shift + Enter with nested bulleted lists content #SkipWebkit', async () => {
             await pageObject.setEditorTextContent('List');
             await pageObject.toggleFooterButton(ToolbarButton.bulletList);

diff --git a/packages/nimble-components/src/rich-text/models/tests/markdown-serializer.spec.ts b/packages/nimble-components/src/rich-text/models/tests/markdown-serializer.spec.ts
@@ -273,7 +273,7 @@ describe('Markdown serializer', () => {
    * Nested bulleted list`);
         });
 
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('Hard break #SkipWebkit', async () => {
             await pageObject.setEditorTextContent('Plain text 1');
             await pageObject.pressShiftEnterKeysInEditor();
@@ -285,7 +285,7 @@ Plain text 2\
 Plain text 3`);
         });
 
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('Hard break with bold #SkipWebkit', async () => {
             await pageObject.toggleFooterButton(ToolbarButton.bold);
             await pageObject.setEditorTextContent('Bold');
@@ -295,7 +295,7 @@ Plain text 3`);
 **Bold**`);
         });
 
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('Hard break with italics #SkipWebkit', async () => {
             await pageObject.toggleFooterButton(ToolbarButton.italics);
             await pageObject.setEditorTextContent('Italics');
@@ -305,7 +305,7 @@ Plain text 3`);
 *Italics*`);
         });
 
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('Hard break with bulleted list #SkipWebkit', async () => {
             await pageObject.setEditorTextContent('Bulleted');
             await pageObject.toggleFooterButton(ToolbarButton.bulletList);
@@ -315,7 +315,7 @@ Plain text 3`);
   list`);
         });
 
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('Hard break with numbered list #SkipWebkit', async () => {
             await pageObject.setEditorTextContent('Numbered');
             await pageObject.toggleFooterButton(ToolbarButton.numberedList);
@@ -325,7 +325,7 @@ Plain text 3`);
    list`);
         });
 
-        // Skipped in Safari: https://github.com/ni/nimble/issues/1938
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1938
         it('Hard break with mention node #SkipWebkit', async () => {
             await appendUserMentionConfiguration(element, [
                 { key: 'user:1', displayName: 'username1' }

diff --git a/packages/nimble-components/src/table/tests/table-column-sizing.spec.ts b/packages/nimble-components/src/table/tests/table-column-sizing.spec.ts
@@ -495,7 +495,7 @@ describe('Table Interactive Column Sizing', () => {
             expect(pageObject.isHorizontalScrollbarVisible()).toBeTrue();
         });
 
-        // Disabled on webkit https://github.com/ni/nimble/issues/1939
+        // WebKit skipped, see https://github.com/ni/nimble/issues/1939
         it('sizing table with a horizontal scrollbar does not change column widths until sized beyond current column pixel widths #SkipWebkit', async () => {
             // create horizontal scrollbar with total column width of 450
             pageObject.dragSizeColumnByRightDivider(2, [100]);