Skip to content

Commit

Permalink
Temporarily disable npm audit of dev dependencies (#802)
Browse files Browse the repository at this point in the history
# Pull Request

## 🀨 Rationale

As described in #801 we have a vulnerability that is causing `npm audit`
to fail the PR build, preventing submissions.

## πŸ‘©β€πŸ’» Implementation

Comment out the audit step that's failing. We'll use the bug linked
above to track re-enabling it.

## πŸ§ͺ Testing

PR build

## βœ… Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
  • Loading branch information
jattasNI authored Nov 2, 2022
1 parent 3ce131f commit c6eb17e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ jobs:

# Audit
- run: npm audit --only=prod
- run: npm audit --audit-level=critical
# https://github.com/ni/nimble/issues/801
# - run: npm audit --audit-level=critical

# Build
- run: npm run build
Expand Down

0 comments on commit c6eb17e

Please sign in to comment.