PR feedback

packages/nimble-components/src/table-column/enum-base/models/mapping-icon-config.ts

@@ -1,28 +1,34 @@
-import { html, when, type ViewTemplate } from '@microsoft/fast-element';
+import { html, type ViewTemplate } from '@microsoft/fast-element';
 import type { IconSeverity } from '../../../icon-base/types';
 import { MappingConfig } from './mapping-config';
 
 export interface IconView {
     severity: IconSeverity;
     text?: string;
 }
+
+// Create an empty template containing only a space because creating a ViewTemplate
+// with an empty string throws an exception at runtime.
+const emptyTemplate = html<IconView>` `;
+
 const createIconTemplate = (
     icon: string | undefined
-): ViewTemplate<IconView> => html`
-    ${when(
-        () => icon,
-        html<IconView>`
-        <${icon!}
+): ViewTemplate<IconView> => {
+    if (icon === undefined) {
+        return emptyTemplate;
+    }
+
+    return html`
+        <${icon}
             title="${x => x.text}"
             role="img"
             aria-label="${x => x.text}"
             severity="${x => x.severity}"
             class="no-shrink"
         >
-        </${icon!}>
-    `
-    )}
-`;
+        </${icon}>
+    `;
+};
 
 /**
  * Mapping configuration corresponding to a icon mapping