Add comments

ni · Feb 28, 2024 · aedd65e · aedd65e
1 parent c6dfd60
commit aedd65e
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/packages/nimble-components/src/select/index.ts b/packages/nimble-components/src/select/index.ts
@@ -651,6 +651,8 @@ export class Select extends FormAssociatedSelect implements ErrorPattern {
     }
 
     public override selectNextOption(): void {
+        // don't call super.selectNextOption as that relies on side-effecty
+        // behavior to not select disabled option (which no longer works)
         for (let i = this.selectedIndex + 1; i < this.options.length; i++) {
             if (!this.options[i]?.disabled) {
                 this.selectedIndex = i;
@@ -660,6 +662,8 @@ export class Select extends FormAssociatedSelect implements ErrorPattern {
     }
 
     public override selectPreviousOption(): void {
+        // don't call super.selectPreviousOption as that relies on side-effecty
+        // behavior to not select disabled option (which no longer works)
         for (let i = this.selectedIndex - 1; i >= 0; i--) {
             if (!this.options[i]?.disabled) {
                 this.selectedIndex = i;