Skip to content

Commit

Permalink
Fix tabs toolbar content alignment (#2451)
Browse files Browse the repository at this point in the history
# Pull Request

## 🤨 Rationale

[SLE bug: Nimble | nimble-tabs-toolbar | alignment of the child elements
has been
altered.](https://dev.azure.com/ni/DevCentral/_workitems/edit/2913486)

## 👩‍💻 Implementation

Just added styling that will expand the `end` slot to fill the rest of
the space of the `Tabs` width.

## 🧪 Testing

There is a Chromatic test in place that is already checking this case,
but I must have glossed over that change when examining it for the
scrollable tabs submission.

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
  • Loading branch information
Jonathan Meyer authored Oct 24, 2024
1 parent c3d9927 commit 64ede95
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix tabs styling.",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
4 changes: 4 additions & 0 deletions packages/nimble-components/src/patterns/tabs/styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,8 @@ export const styles = css`
.scroll-button.right {
margin-left: ${smallPadding};
}
[part='end'] {
flex: 1;
}
`;

0 comments on commit 64ede95

Please sign in to comment.