Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add docs and test for table column header text inside a <span> (#1877)
# Pull Request ## 🤨 Rationale [Some localization use cases](https://dev.azure.com/ni/DevCentral/_git/Skyline/pullrequest/661277?_a=files&path=/Web/Workspaces/SystemLinkShared/projects/asset-manager-lib/src/assets/asset-move-dialog/asset-move-dialog.component.html) require placing table header text inside a span rather than being text content of the header. This works fine today (text is rendered all caps, ellipsized when necessary, title set when necessary) but we don't document or test this case. ## 👩💻 Implementation 1. Add a note in storybook that this is allowed 2. Add a unit test to ensure title is set ## 🧪 Testing 1. New unit test for title. 2. Looked for unit / chromatic tests for ellipsis but didn't see any to copy and didn't think it was worth writing one for this case 3. Locally verified in Angular example app that header text in a span behaves identically to header text as text content ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [ ] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: Milan Raj <[email protected]>
- Loading branch information