-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Dependency Updates for December 2024 (#2485)
# Pull Request ## 🤨 Rationale Updates dependencies manually to address build issues revealed by #2482 #2481 #2480. Found that just updating dependencies by rebuilding the lock fails the build which means the [repo is in a bad state](#1479 (comment)) and that should be addressed quickly. ## 👩💻 Implementation - Update major deps and rebuild lock - Found that the now [deprecated tiptap link validate](https://tiptap.dev/docs/editor/extensions/marks/link#validate-deprecated) function is expected to still function with [backwards compat](ueberdosis/tiptap#5812) however there seems to be a regression as it [fails our build by allowing autolinking of unexpected protocols](https://github.com/ni/nimble/actions/runs/12110590706/job/33761233944#step:17:613). - Switched from tiptap link validate to [shouldAutoLink](https://tiptap.dev/docs/editor/extensions/marks/link#shouldautolink) as described by docs. That seems to not fail the build. - Pushed the min semver range version up for all the tiptap / prosemirror packages as otherwise it seems to[ fail build when type checking libraries](ueberdosis/tiptap#5867). **NOTE**: It seems to be transitive dependency type issues that will fail builds, I think it's possible that minimal upgrades done by renovate may hit issues in app updates. If an app adopting latest these changes fails to build it may need to rebuild the lock files in a clean workspace to align transitive deps on latest versions and avoid library type check issues. - Updates to [prettier 3.4](https://prettier.io/blog/2024/11/26/3.4.0.html) resulting in lots of changes. ## 🧪 Testing Rely on CI. ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
- Loading branch information
Showing
89 changed files
with
2,990 additions
and
2,755 deletions.
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@ni-nimble-components-2928e7be-919f-4a54-8ad3-a37ba46eb5fe.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "patch", | ||
"comment": "Update rich text dependencies", | ||
"packageName": "@ni/nimble-components", | ||
"email": "[email protected]", | ||
"dependentChangeType": "patch" | ||
} |
7 changes: 7 additions & 0 deletions
7
change/@ni-spright-components-ec147704-81e1-455a-8ef3-16621b69ba3b.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "patch", | ||
"comment": "Updates from lint changes", | ||
"packageName": "@ni/spright-components", | ||
"email": "[email protected]", | ||
"dependentChangeType": "patch" | ||
} |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.