-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Write to system log API from Vireo #694
Conversation
@MalleshSushmitha is there a reason this was changed to a Draft PR? Is it not ready for review? |
@rajsite I was not aware that owners will be added as soon as I create a PR here. I changed it to draft since I haven't gotten this reviewed locally by anyone in the team. |
@MalleshSushmitha Thanks for clarifying. Just making sure it was intentional. Will review when it is changed out of draft 👍 |
@rajsite This is ready for review now. |
@MalleshSushmitha sorry for the delay, I expect to review this tomorrow |
@MalleshSushmitha , would you mind referencing the NXG side commits/PRs that implement the feature for reference? |
@sanmut I have modified to include a link to the PR in the description. |
Bypassing @cglzaguilar and @spathiwa who are required reviewers but this is a pretty simple change that effectively reverts #570 |
@MalleshSushmitha A new Vireo was released with these changes. Make sure to update Vireo in ASW. |
The Write to system log API for the Vireo target is now built using JSLI in the NXG code base(it was previously using an SLI).
So we no longer need this function definition in the Vireo code base.
Note:
I have also removed the tests related to the same function.
PR for changes on the NXG codebase: PR