uncomment deletion_protection_enabled, add Version to ingestion_bucke… (

#209) * uncomment deletion_protection_enabled, add Version to ingestion_bucket_policy * run terraform fmt
nhsconnect · Jul 24, 2024 · dad9d96 · dad9d96
1 parent f00fffc
commit dad9d96
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/terraform/dynamodb.tf b/terraform/dynamodb.tf
@@ -1,8 +1,8 @@
 resource "aws_dynamodb_table" "suspensions" {
-  name         = "${var.environment}-${var.component_name}-dynamodb"
-  billing_mode = "PAY_PER_REQUEST"
-  hash_key     = "nhs_number"
-  #  deletion_protection_enabled = true
+  name                        = "${var.environment}-${var.component_name}-dynamodb"
+  billing_mode                = "PAY_PER_REQUEST"
+  hash_key                    = "nhs_number"
+  deletion_protection_enabled = true
 
   server_side_encryption {
     enabled     = true

diff --git a/terraform/main.tf b/terraform/main.tf
@@ -1,5 +1,5 @@
 provider "aws" {
-  region  = var.region
+  region = var.region
 }
 
 terraform {

diff --git a/terraform/modules/suspension-service/s3.tf b/terraform/modules/suspension-service/s3.tf
@@ -47,6 +47,7 @@ resource "aws_s3_bucket_public_access_block" "ingestion_bucket" {
 resource "aws_s3_bucket_policy" "ingestion_bucket_policy" {
   bucket = aws_s3_bucket.ingestion_bucket.id
   policy = jsonencode({
+    "Version": "2008-10-17",
     "Statement" : [
       {
         Effect : "Deny",