perf(store): prevent initializing state factory at feature levels #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 456efc0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
|
commit: |
BundleMonFiles updated (1)
Unchanged files (5)
Total files change -1.04KB -0.8% Groups updated (2)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Unchanged files (9)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (3)
Total files change -264B -0.13% Final result: ✅ View report in BundleMon website ➡️ |
arturovt
force-pushed
the
perf/state-factory
branch
from
7c5e5e9
to
23c9ff5
Compare
In this commit, we mark the state factory as a root provider to prevent its initialization at feature levels when `provideStates` is called. Previously, the state factory was initialized at feature levels because it needed to retrieve the feature-level injector in order to call `injector.get(FeatureStateClass)`. This was necessary because, when `NgxsModule.forFeature([BlogState])` was called, the `BlogState` instance could only be retrieved from the feature injector hierarchy. Now, since `addAndReturnDefaults` is called at the feature level inside the feature environment initializer, it is executed within the feature injection context, allowing us to use the `inject(...)` function directly.
arturovt
force-pushed
the
perf/state-factory
branch
from
23c9ff5
to
456efc0
Compare
|
Code Climate has analyzed commit 456efc0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
arturovt
requested review from
markwhitfeld,
kuncevic,
Carniatto,
poloagustin,
joaqcid and
splincode
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we mark the state factory as a root provider to prevent its initialization
at feature levels when
provideStatesis called.Previously, the state factory was initialized at feature levels because it needed to retrieve
the feature-level injector in order to call
injector.get(FeatureStateClass).This was necessary because, when
NgxsModule.forFeature([BlogState])was called, theBlogStateinstance could only be retrieved from the feature injector hierarchy.
Now, since
addAndReturnDefaultsis called at the feature level inside the feature environmentinitializer, it is executed within the feature injection context, allowing us to use the
inject(...)function directly.