build(deps): upgrade angular 11 #1269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lulzzz
previously approved these changes
Dec 10, 2020
|
Would fix #1270 |
|
@lulzzz please review my pr |
|
@ocombe any news on this ? |
|
As explained in #1270 we don't need to change the peer dependencies, the lib works just fine as it is... |
feech
reviewed
Feb 9, 2021
| @@ -10,7 +10,7 @@ | |||
| "prefix": "lib", | |||
| "architect": { | |||
| "build": { | |||
| "builder": "@angular-devkit/build-ng-packagr:build", | |||
| "builder": "@angular-devkit/build-angular:ng-packagr", | |||
There was a problem hiding this comment.
Deprecated @angular-devkit/build-ng-packagr has been removed in angular 11
More details please see build: delete @angular-devkit/build-ng-packagr
feech
approved these changes
Feb 10, 2021
feech
approved these changes
Feb 10, 2021
adio87
reviewed
Feb 19, 2021
| @@ -45,4 +45,8 @@ export class TranslateStore { | |||
| * }); | |||
| */ | |||
| public onDefaultLangChange: EventEmitter<DefaultLangChangeEvent> = new EventEmitter<DefaultLangChangeEvent>(); | |||
|
|
|||
| constructor() { | |||
| this.currentLang = this.currentLang; | |||
There was a problem hiding this comment.
Suggested change
| this.currentLang = this.currentLang; | |
| this.currentLang = this.this.defaultLang; |
lulzzz
approved these changes
Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.