Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add log level-scoped methods to LumberjackService #186

Merged
merged 3 commits into from
Dec 29, 2023
Merged

Conversation

LayZeeDK
Copy link
Member

@LayZeeDK LayZeeDK commented Dec 29, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

A pull request from a forked repo is untrusted so the SonarCloud secret is not passed.

Issue Number:

What is the new behavior?

This pull request is trusted so the SonarCloud secret is passed.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

nx-cloud bot commented Dec 29, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 59e5c9a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


⌛ The following target is in progress

✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@LayZeeDK LayZeeDK changed the title Pr/181 feat: add log level-scoped methods to LumberjackService Dec 29, 2023
@LayZeeDK LayZeeDK marked this pull request as ready for review December 29, 2023 05:07
@LayZeeDK LayZeeDK force-pushed the pr/181 branch 2 times, most recently from 97d2ee2 to 59e5c9a Compare December 29, 2023 05:29
Copy link

sonarcloud bot commented Dec 29, 2023

Copy link
Contributor

@NachoVazquez NachoVazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@NachoVazquez NachoVazquez merged commit d446427 into main Dec 29, 2023
19 of 20 checks passed
@NachoVazquez NachoVazquez deleted the pr/181 branch December 29, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: a simpler logging service accepting log message and log payload
3 participants