Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update to sonarsource/sonarcloud-github-action v2.0.0 #177

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

LayZeeDK
Copy link
Member

@LayZeeDK LayZeeDK commented Aug 19, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

We are using sonarsource/sonarcloud-github-action v1.7 and pull requests are unable to pass because of a missing SonarCloud report. This version uses an old version of Java no longer supported by SonarCloud.

Issue Number: N/A

What is the new behavior?

We are using sonarsource/sonarcloud-github-action v2.0.0

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

No breaking changes between v1.7 and v2.0.0 according to their GitHub Releases.

@nx-cloud
Copy link

nx-cloud bot commented Aug 19, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6f6b8f3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

Copy link
Contributor

@NachoVazquez NachoVazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@LayZeeDK LayZeeDK merged commit 0b457f2 into main Aug 19, 2023
12 checks passed
@LayZeeDK LayZeeDK deleted the ci/update-sonarcloud-action branch August 19, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants