Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manually set @angular/platform-browser as optional peerDependency #174

Merged

Conversation

NachoVazquez
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

@angular/platform-browser is being added automatically as a peer dependency to the package.json on the build but is not treated manually.

Closes: #170

What is the new behavior?

We manually set @angular/platform-browser as an optional peerDependency on the package.json.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@nx-cloud
Copy link

nx-cloud bot commented Aug 16, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 45ae509. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@NachoVazquez NachoVazquez merged commit 3c9b3b1 into main Aug 16, 2023
12 checks passed
@NachoVazquez NachoVazquez deleted the fix/manually-set-platform-browser-to-peer-dependencies branch August 16, 2023 18:41
LayZeeDK added a commit that referenced this pull request Aug 19, 2023
LayZeeDK added a commit that referenced this pull request Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to use lumberjack for angular 16
2 participants