Skip to content

Commit

Permalink
build: migrate to ngx-deploy-npm v8 (#200)
Browse files Browse the repository at this point in the history
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] The commit message follows our guidelines: CONTRIBUTING.md#commit
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] Docs have been added / updated (for bug fixes / features)

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

```
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
```

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Closes: #198 

## What is the new behavior?

Update ngx-deploy-npm to 8.0.0.

## Does this PR introduce a breaking change?

```
[ ] Yes
[x] No
```

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

Original PR by @dianjuar 

More information about the changes and their motivation can be found on
this [blog
post](https://dev.to/dianjuar/whats-coming-to-ngx-deploy-npm-v8-23gn)

Co-authored-by: dianjuar <[email protected]>
  • Loading branch information
NachoVazquez and dianjuar authored Jan 23, 2024
1 parent e4016fc commit 08b54ba
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"jest-environment-jsdom": "29.4.3",
"jest-preset-angular": "13.1.1",
"ng-packagr": "16.2.3",
"ngx-deploy-npm": "6.0.0",
"ngx-deploy-npm": "8.0.0",
"nx": "16.7.0",
"nx-cloud": "16.5.2",
"postcss": "8.4.18",
Expand Down
5 changes: 3 additions & 2 deletions packages/ngworker/lumberjack/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"preid": "beta",
"syncVersions": false,
"commitMessageFormat": "release(${projectName}): 🎸 cut release to ${version}",
"postTargets": ["ngworker-lumberjack:github", "ngworker-lumberjack:publish"]
"postTargets": ["ngworker-lumberjack:build", "ngworker-lumberjack:github", "ngworker-lumberjack:publish"]
}
},
"github": {
Expand All @@ -111,7 +111,8 @@
"options": {
"access": "public",
"distFolderPath": "dist/packages/ngworker/lumberjack"
}
},
"dependsOn": ["build"]
}
},
"tags": ["scope:public", "type:package"],
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -12606,10 +12606,10 @@ [email protected]:
optionalDependencies:
esbuild "^0.19.0"

ngx-deploy-npm@6.0.0:
version "6.0.0"
resolved "https://registry.yarnpkg.com/ngx-deploy-npm/-/ngx-deploy-npm-6.0.0.tgz#860675a7f08efd9058ed2be62ce031ab2c7ae9c2"
integrity sha512-gfj4ZIAguZ4JJF/WOIGYktwi1BKtHRYz1TUJV4a5qBwRaBunSu1/oW9K+sApwGfegMtrblDjMoLl10OZWgqx+A==
ngx-deploy-npm@8.0.0:
version "8.0.0"
resolved "https://registry.yarnpkg.com/ngx-deploy-npm/-/ngx-deploy-npm-8.0.0.tgz#8f0c72e36db443df950a043677b030500d4c117d"
integrity sha512-/sjvCYXp7fDc45uYsRwxCfJGZh82n2e7B3eazlS4jx6rE1DOvRtlbJIqptHL486iIDd63yCAQOXqeFqGvgGtRw==

nice-napi@^1.0.2:
version "1.0.2"
Expand Down

0 comments on commit 08b54ba

Please sign in to comment.