Missing events and custom key repetition frequency #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…StreamDeck "Hold Parameter"
nguyenquyhy
reviewed
Jun 13, 2021
|
Hi,
I managed to create a pull request.
No, the only reason I did it is because I didn't know the history and didn't know if I break other features.
Feel free to remove the if condition.
Kind regards
Martin
BlueMail for Android herunterladen
Am 13. Juni 2021, 20:04, um 20:04, "Nguyễn Quý Hy" ***@***.***> schrieb:
***@***.*** commented on this pull request.
…
> timer.Elapsed += Timer_Elapsed;
timer.Start();
}
return Task.CompletedTask;
}
+ private int
GetRepeatFrequencyForMobiflightSettings(GenericToggleSettings settings,
int defaultFreq)
May I know if there is any reason this is specific for MobiFlight? For
me the beauty of MobiFlight is that it doesn't need specific support
from the plugin: it just works seamlessly with SimConnect.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#261 (review)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added heading bug events.
I need different delays to be able to dial in frequencies or change heading bug. That way, the user can choose.