Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🔥 First punt at priority option #223

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

feat: 🔥 First punt at priority option #223

wants to merge 45 commits into from

Commits on Mar 16, 2022

  1. feat: 🔥 First punt at priority option 

    Allow user to set length priority to length or unique (POC)

✅ Closes: #220
    Ryan Smee committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    6160c3c View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. Merge remote-tracking branch 'origin/main' into feat/220-unique-values

    @theryansmee
    theryansmee committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    485782e View commit details
    Browse the repository at this point in the history

  2. feat: 🔥 Clean up fakFromArray logic 

    Move randUniqueElement logic into fakFromArray. Simplified
fakeFromFunction while loop logic

#220
    @theryansmee
    theryansmee committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    6b57aa0 View commit details
    Browse the repository at this point in the history

  3. feat: 🔥 Replace use of random index logic with getRandomInRange 

    ✅ Closes: #220
    @theryansmee
    theryansmee committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    713c77d View commit details
    Browse the repository at this point in the history

  4. feat: 🔥 Revert rand element logic for now 

    ✅ Closes: #220
    @theryansmee
    theryansmee committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    bbe7b0b View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. feat: 🔥 Allow devs to pass in comparison functions 

    Add default comparison functions for most likely use cases. Implimented
them

✅ Closes: #220
    @theryansmee
    theryansmee committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    7f69bad View commit details
    Browse the repository at this point in the history

  2. feat: 🔥 Add custom comparison functions non-conforming function 

    ✅ Closes: #220
    @theryansmee
    theryansmee committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    77831a5 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. Merge remote-tracking branch 'origin/main' into feat/220-unique-values

    @theryansmee
    theryansmee committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    96acb7e View commit details
    Browse the repository at this point in the history

  2. feat: 🔥 Add json check unique function. Clean up code 

    ✅ Closes: #220
    @theryansmee
    theryansmee committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    af09284 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2022

  1. feat: 🔥 Add generic comparison function 

    Add comparison function and start change over to using it

✅ Closes: #220
    Ryan Smee committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    6833592 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. feat: 🔥 Replace duplicate checkUnique logic with objectIsUnique 

    ✅ Closes: #220
    Ryan Smee committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    13998f6 View commit details
    Browse the repository at this point in the history

  2. feat: 🔥 Fix function name. Update file name

    Ryan Smee committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    717bb7d View commit details
    Browse the repository at this point in the history

  3. test: 🥳 Move error to snapshot

    Ryan Smee committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    660f53a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Merge remote-tracking branch 'origin/main' into feat/220-unique-values

    Ryan Smee committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    b18c227 View commit details
    Browse the repository at this point in the history

  2. feat: 🔥 Fix snapshot 

    Fix snapshot error. Ensure all thrown errors throw actual errors rather
than strings

✅ Closes: #220
    Ryan Smee committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    42a54d4 View commit details
    Browse the repository at this point in the history

  3. feat: 🔥 Move snapshots folder to tests/ route

    Ryan Smee committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    0ec65be View commit details
    Browse the repository at this point in the history

  4. feat: 🔥 Clean up core file

    Ryan Smee committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    ff6980a View commit details
    Browse the repository at this point in the history

  5. feat: 🔥 Add missing priority doc comment 

    Add missing priority doc comment

✅ Closes: #220
    Ryan Smee committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    d57bd25 View commit details
    Browse the repository at this point in the history

  6. test: 🥳 Replace flakey regex

    Ryan Smee committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    fc5f8fc View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Merge remote-tracking branch 'origin/main' into feat/220-unique-values 

    # Conflicts:
#	packages/falso/src/lib/core/core.ts
    Ryan Smee committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    67c4f5f View commit details
    Browse the repository at this point in the history

  2. feat: 🔥 return empty array if length is 0 

    ✅ Closes: #220
    Ryan Smee committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    2b84b1a View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. Merge remote-tracking branch 'origin/main' into feat/220-unique-values

    Ryan Smee committed May 3, 2022
    Configuration menu
    Copy the full SHA
    d4d1fa3 View commit details
    Browse the repository at this point in the history

  2. feat: 🔥 clean up unique validators 

    Move validators to own file. Rename validators to follow similar naming
convention

✅ Closes: #220
    Ryan Smee committed May 3, 2022
    Configuration menu
    Copy the full SHA
    32b84de View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. Merge remote-tracking branch 'origin/main' into feat/220-unique-values

    Ryan Smee committed May 6, 2022
    Configuration menu
    Copy the full SHA
    6f7dcc6 View commit details
    Browse the repository at this point in the history

  2. feat: 🔥 Add tests for unique validators 

    (Still need to do tests for objectIsUnique)

✅ Closes: #220
    Ryan Smee committed May 6, 2022
    Configuration menu
    Copy the full SHA
    2d0aecc View commit details
    Browse the repository at this point in the history

  3. feat: 🔥 Fix reversed logic and corresponding tests 

    ✅ Closes: #220
    Ryan Smee committed May 6, 2022
    Configuration menu
    Copy the full SHA
    dbddca3 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. feat: 🔥 Combine uniqueComparer and comparisonKeys into config 

    ✅ Closes: #220

feat: 🔥 Combine uniqueComparer and comparisonKeys into config

✅ Closes: #220
    Ryan Smee committed May 10, 2022
    Configuration menu
    Copy the full SHA
    2331772 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into feat/220-unique-values 

    # Conflicts:
#	packages/falso/jest.config.ts
#	packages/falso/src/tests/random-float.spec.ts
    Ryan Smee committed May 10, 2022
    Configuration menu
    Copy the full SHA
    b54d6b2 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. Merge remote-tracking branch 'origin/main' into feat/220-unique-values

    Ryan Smee committed May 12, 2022
    Configuration menu
    Copy the full SHA
    39e7fa5 View commit details
    Browse the repository at this point in the history

  2. feat: 🔥 Simplify priority documentation comment 

    ✅ Closes: #220
    Ryan Smee committed May 12, 2022
    Configuration menu
    Copy the full SHA
    e29cc7f View commit details
    Browse the repository at this point in the history

  3. feat: 🔥 Tweak documentation comment to be priority specific 

    ✅ Closes: #220
    Ryan Smee committed May 12, 2022
    Configuration menu
    Copy the full SHA
    641a875 View commit details
    Browse the repository at this point in the history

  4. feat: 🔥 Revert package.lock 

    ✅ Closes: #220

feat: 🔥 Revert package.lock

✅ Closes: #220
    Ryan Smee committed May 12, 2022
    Configuration menu
    Copy the full SHA
    c48790a View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. Merge remote-tracking branch 'origin/main' into feat/220-unique-values

    Ryan Smee committed May 23, 2022
    Configuration menu
    Copy the full SHA
    f29cca6 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. Merge remote-tracking branch 'origin/main' into feat/220-unique-values 

    # Conflicts:
#	packages/falso/src/lib/core/core.ts
#	packages/falso/src/lib/text.ts
    Ryan Smee committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    e7dac07 View commit details
    Browse the repository at this point in the history

  2. feat: 🔥 Fix merge conflicts in core 

    ✅ Closes: #220
    Ryan Smee committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    77edc54 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Merge remote-tracking branch 'origin/main' into feat/220-unique-values 

    # Conflicts:
#	packages/falso/src/lib/number.ts
#	packages/falso/src/lib/octal.ts
    Ryan Smee committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    fee5cf6 View commit details
    Browse the repository at this point in the history

  2. fix: 🐞 Fix outdated tests 

    ✅ Closes: 220
    Ryan Smee committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    23f628e View commit details
    Browse the repository at this point in the history

  3. refactor: 💡 Remove commented out code 

    ✅ Closes: 220
    Ryan Smee committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    e2fb265 View commit details
    Browse the repository at this point in the history

  4. test: 🥳 Add basic tests for core fake function 

    Add tests for simple array and function scenarios. Fix typo in unique
checker logic

✅ Closes: 220
    Ryan Smee committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    086ec7b View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2022

  1. refactor: 💡 Code review changes 

    Change comparison of valueOf to getTime with dateIsUnique. Combine
describe block and it labels for comparison function tests

✅ Closes: 220
    Ryan Smee committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    2e5b650 View commit details
    Browse the repository at this point in the history

  2. refactor: 💡 Code review changes 

    Change checkUnique arrow functions to function declorations. Change unique-validators from inline arrow functions to actual function. Make function more type safe

✅ Closes: 220
    Ryan Smee committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    10cd7d0 View commit details
    Browse the repository at this point in the history

  3. refactor: 💡 Change request changes 

    Strengthen type checking. Remove redundant error and test

✅ Closes: 220
    Ryan Smee committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    274fdc9 View commit details
    Browse the repository at this point in the history

  4. refactor: 💡 Code review changes 

    Strengthen type checking for comparisonKeys

✅ Closes: 220
    Ryan Smee committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    1143091 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Update packages/falso/src/lib/core/core.ts 

    Co-authored-by: Shahar Kazaz <[email protected]>
    @theryansmee @shaharkazaz
    theryansmee and shaharkazaz authored Sep 19, 2022
    Configuration menu
    Copy the full SHA
    2a037d0 View commit details
    Browse the repository at this point in the history

  2. refactor: 💡 Code review changes 

    Change type back to original. Move option.length short circuit checks into fakeFromFunction/fakeFromArray functions. 
Fix typos in checkUnique logic for randJSON & randNearbyGPSCoordinate.
Add missing tests tests.

✅ Closes: 220
    Ryan Smee committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    8869b35 View commit details
    Browse the repository at this point in the history