-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate access control example to documentation website #6572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates the access control example to the documentation website, converting the existing README into a page formatted for the production website. It also cleans up the frontmatter of the surrounding documents so that pages can be more easily re-arranged in the future. The converted page make use of single source embedded code blocks using files in the GitHub repository, as well as a highlighting feature of code blocks that has not been used in previous documentation.
✅ Deploy Preview will be available once build job completes!
|
for more information, see https://pre-commit.ci
…es-ingress into docs/example-migration
vepatel
reviewed
Oct 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6572 +/- ##
==========================================
- Coverage 53.08% 53.00% -0.08%
==========================================
Files 87 87
Lines 16200 16223 +23
==========================================
Hits 8599 8599
- Misses 7194 7217 +23
Partials 407 407 ☔ View full report in Codecov by Sentry. |
jputrino
reviewed
Oct 3, 2024
jputrino
reviewed
Oct 3, 2024
jputrino
reviewed
Oct 3, 2024
jputrino
reviewed
Oct 3, 2024
jputrino
reviewed
Oct 3, 2024
Co-authored-by: Jodie Putrino <[email protected]> Signed-off-by: Alan Dooley <[email protected]>
vepatel
approved these changes
Oct 14, 2024
j1m-ryan
reviewed
Oct 15, 2024
j1m-ryan
approved these changes
Oct 15, 2024
AlexFenlon
approved these changes
Oct 15, 2024
pdabelf5
approved these changes
Oct 15, 2024
nginx-bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
This commit migrates the access control example to the documentation website, converting the existing README into a page formatted for the production website. It also cleans up the frontmatter of the surrounding documents so that pages can be more easily re-arranged in the future. The converted page make use of single source embedded code blocks using files in the GitHub repository, as well as a highlighting feature of code blocks that has not been used in previous documentation. Co-authored-by: Jodie Putrino <[email protected]> Co-authored-by: Venktesh Shivam Patel <[email protected]> Co-authored-by: Jakub Jarosz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Pull requests/issues for documentation
needs cherry pick
Cherry pick this PR into a release branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request migrates the access control example to the documentation website, converting the existing README into a page formatted for the production website. It also cleans up the frontmatter of the surrounding documents so that pages can be more easily re-arranged in the future.
The converted page makes use of single source embedded code blocks using files in the GitHub repository, as well as a highlighting feature of code blocks that has not been used in previous documentation.
Checklist
Before creating a PR, run through this checklist and mark each as complete.