Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTelemetry: add compression option #920

Merged
merged 35 commits into from
Nov 25, 2024
Merged

OpenTelemetry: add compression option #920

merged 35 commits into from
Nov 25, 2024

Conversation

sean-breen
Copy link

Proposed changes

Adds the compression option to the agent.conf OTel collector config. Possible values for this are:

  • none
  • gzip
  • snappy
  • zstd

Example:

  exporters:
    otlp_exporters:
      - server:
          host: "otel-collector"
          port: 6969
        compression: gzip
        ...

Information on the pros/cons of each compression format and comparisons between them are available at the OpenTelemetry repo here

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@sean-breen sean-breen requested a review from a team as a code owner November 7, 2024 17:01
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 7, 2024
@oCHRISo oCHRISo added v3.x Issues and Pull Requests related to the major version v3 enhancement New feature or request and removed chore Pull requests for routine tasks labels Nov 7, 2024
aphralG and others added 6 commits November 11, 2024 15:51
@aphralG @dhurley @sean-breen
Update config apply diagrams (#914)
185524e 
* update diagrams
---------

Co-authored-by: dhurley <[email protected]>
@dhurley @sean-breen
Add testing NGINX Agent section to README (#913)
af33df0
@oliveromahony @sean-breen
Add more detail to subject and issuer (#915)
149f108 
* added cert meta for subject and issuer
@RRashmit @sean-breen
chore: add missed integration test (#921)
dc66468
@RRashmit @sean-breen
Add support for Agent connection to mpi regardless of NGINX Instance …
376eab4 
…status (#916)

* chore: allow commander service to connect irrespective of nginx availability

* chore: unit test

* chore: integration test

* chore: refactored

* chore: remove extra code

* chore: updated build target

* chore: updating variables

* chore: separated nginx less test from official agent testing
@dhurley @sean-breen
Fail release job if packages fail to publish. (#922)
1d28aa0
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Nov 11, 2024
@oliveromahony oliveromahony merged commit ca1c468 into v3 Nov 25, 2024
20 checks passed
@oliveromahony oliveromahony deleted the otel-add-compression-option branch November 25, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RRashmit RRashmit RRashmit approved these changes

@dhurley dhurley dhurley approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation enhancement New feature or request v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sean-breen @oliveromahony @dhurley @RRashmit @oCHRISo @aphralG