-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added script to generate ucan for w3up space and docs for how to access the space using console.web3.storage #2554
Conversation
…ss the space using console.web3.storage
Deploying nft-storage with Cloudflare Pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2554 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 1324 1324
=========================================
Hits 1324 1324 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hemmed and hawwed a bit but you can safely ignore - this is fantastic!
|
||
The credentials used in staging/production are in the usual vault of secrets under 'w3up credentials'. | ||
|
||
Run the cli command `w3up console ucan generate` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe better to use the yarn command?
Run the cli command `w3up console ucan generate` | |
Run the cli command `yarn w3up:console:ucan:generate` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by 'the cli command' I meant 'arguments passed to the ./scripts/cli.js I found'. So I think the way I wrote it was ambiguous and probably should change, but not necessarily to one that mentions yarn.
```shell | ||
( | ||
cd packages/api | ||
node scripts/cli.js w3up console ucan generate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh lol but I just noticed this - also seems fine. Since this README is already in the packages/api
directory it feels a little weird to have that here BUT it's unambiguous, where omitting it wouldn't be. Overall I think you could go either way, so maybe just ignore this and the previous comment ;-p
🤖 I have created a release *beep* *boop* --- ## [4.6.0](api-v4.5.0...api-v4.6.0) (2024-04-04) ### Features * added script to generate ucan for w3up space and docs for how to access the space using console.web3.storage ([#2554](#2554)) ([ad33faf](ad33faf)) * lock w3up uploads feature switch open ([#2556](#2556)) ([6eeefeb](6eeefeb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Context
What?
How to Test