Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature excel delete building blocks #497

Merged
merged 6 commits into from
Jul 31, 2024

Conversation

Etschbeijer
Copy link
Collaborator

closes #495

@Etschbeijer Etschbeijer changed the base branch from main to developer July 30, 2024 14:22
@Etschbeijer Etschbeijer marked this pull request as ready for review July 30, 2024 14:22
@Etschbeijer Etschbeijer requested a review from Freymaurer July 30, 2024 14:22
Copy link
Collaborator

@Freymaurer Freymaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic from removeSelectedAnnotationBlock seems overly complicated, are you sure this cannot be improved?

@@ -66,6 +66,27 @@ module OfficeInteropExtensions =
values = U4.Case1 col
)



static member adoptTableFormats (table:Table, context:RequestContext) =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some function which did something similiar. This will be important for another one of the quickaccess buttons. Add a parameter which toggles hide or unhide.

if true -> hide all reference columns
if false -> unhide all columns

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Etschbeijer
Copy link
Collaborator Author

@Freymaurer Somehow I cannot comment on your one comment so I do it that way:
I will look into it tomorrow.
The problem is that I have to catch the free text columns that are neither main nor property columns and I cannot utilize Arc Tables efficiently due to the difference in naming and index.

@Etschbeijer Etschbeijer merged commit 15a7d06 into developer Jul 31, 2024
@Freymaurer Freymaurer deleted the Feature_Excel_DeleteBuildingBlocks branch October 28, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Excel]: Remove building block
2 participants