-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to analyse only mitochondria #608
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the docs as well, to add the new analysis_type? And if there are any changes to the output.
|
||
emit: | ||
vcf = SVDB_MERGE.out.vcf // channel: [ val(meta), path(vcf)] | ||
tbi = TABIX_TABIX.out.tbi // channel: [ val(meta), path(tbi)] | ||
vcf = ch_merged_svs // channel: [ val(meta), path(vcf)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If only mito analysis is run, are no SV calls emitted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SV in mitochondria will be emitted, but not the nuclear genome if that's what you are asking? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so the mitochondria SVs are not input into SVDB_MERGE and emitted as ch_merged_svs, that is only the nuclear genome?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see what you mean. That does include nuclear genome and mt genome, but the difference is those calls are in vcf format. mito
analysis at the moment does not generate SV calls in vcf format. I can update the documentation to make this clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would be good, to clarify if the SV calls in VCF format contains MT calls or not, just as you have done for the SNV VCFs 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if you run with --analysis_type mito
no VCFs are procured, only the output files from CALL_SV_MT
? Or are any of MANTA, TIDDIT, GERMLINECNVCALLER or CNVNATOR be run at the same time as --analysis_type mito
?
And if you run with wgs
, both the output files from CALL_SV_MT
, as well as mitochondrial variants in VCF format from the callers in CALL_STRUCTURAL_VARIANTS
are output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yupe. That's right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
PR checklist
I have added a new analysis type (mito) to call and annotate only mitochondrial variants.
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).