Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial draft of netmhciipan module #252

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Add initial draft of netmhciipan module #252

merged 4 commits into from
Dec 16, 2024

Conversation

jonasscheid
Copy link
Contributor

Initial draft of NetMHCIIpan module #250

  • Implements newest version 4.3e
  • Initial parsing around the module
  • Breaks current main workflow. Needs to get adjusted in future PRs.
  • WIP: Supported allele checks that should be handled in local utils subworkflow

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/epitopeprediction branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

nf-core pipelines lint overall result: Failed ❌

Posted for pipeline commit bf6dc84

+| ✅ 218 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   1 tests had warnings |!
-| ❌   3 tests failed       |-

❌ Test failures:

  • nextflow_config - Config default value incorrect: params.max_peptide_length_classI is set as 11 in nextflow_schema.json but is 14 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.min_peptide_length_classII is set as 15 in nextflow_schema.json but is 8 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.max_peptide_length_classII is set as 16 in nextflow_schema.json but is 25 in nextflow.config.

❗ Test warnings:

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-epitopeprediction_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-epitopeprediction_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-epitopeprediction_logo_dark.png

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-16 10:40:44

@jonasscheid jonasscheid merged commit cea2e54 into nf-core:mhc-binding-subworkflow Dec 16, 2024
4 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonasscheid @nf-core-bot