Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude version.yml from publishDirs #1100

Merged
merged 1 commit into from
Dec 3, 2024
Merged

exclude version.yml from publishDirs #1100

merged 1 commit into from
Dec 3, 2024

Conversation

TCLamnidis
Copy link
Collaborator

Corrects the implementation of #1099.
The approved way of excluding the versions.yml is with the saveAs attribute, not pattern.

Maybe this snippet should be added to all modules? 🤔

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@TCLamnidis TCLamnidis merged commit ef558bc into dev Dec 3, 2024
1 of 18 checks passed
@TCLamnidis TCLamnidis deleted the TCLamnidis-patch-1 branch December 3, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants