Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #69 nanoplot error #70

Closed
wants to merge 2 commits into from
Closed

Fixes #69 nanoplot error #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9599673
Merge pull request #59 from nf-core/dev
d4straub Aug 27, 2021
3981e7d
removing png output from NANOPLOT as causing failure
drchriscole Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion modules/local/nanoplot.nf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ process NANOPLOT {

output:
tuple val(meta), path("*.html"), emit: html
tuple val(meta), path("*.png") , emit: png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could also make that one optional ...? with optional: true ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that optional output might be better, but thats just just a band aid here, so I think its fine.
The optimal solution might be to make NanoPlot output the png again? I mean it was sort of nice to look at them?!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that static image generation is now dependent on having an internet connection, which cannot always be guaranteed. See: wdecoster/NanoPlot#281

The HTML reports are unaffected so still can visualise the plots. Making the pngs optional could be a pragmatic solution and doesn't cause the workflow to fail on occasions when internet access is unavailable.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
No, an internet connection may not be a prerequisite to run the pipeline.
So I am fine with the PR ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree then too!

tuple val(meta), path("*.txt") , emit: txt
tuple val(meta), path("*.log") , emit: log
path "*.version.txt" , emit: version
Expand Down