Use ingest/scripts to match phylogenetic/scripts
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm all for consistency! Noting that there is a split across @nextstrain:
If zika was just a one-off then I would suggest being consistent with other repos. But there's a clear lack of consistency across many repos. Let's open an issue in nextstrain/private where we can discuss and decide which to use, then update this PR + other repos with the decision? |
j23414
changed the title
phylogenetic/bin to match ingest/biningest/scripts to match phylogenetic/scripts
|
Updated this PR with the decision to use "scripts" instead of "bin". Ready for review |
genehack
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
While chatting about a standard directory structure of the pathogen repository, we noticed that zika was using both
phylogenetic/scriptsandingest/bin.This PR picks
binto keep things consistent.Additionally, deleted an unused script.
Related issue(s)
Checklist