-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
wip! Remove credentials from config in favor of environment variables
This is more standard (e.g. follows the 12 factor app pattern) and, as Trevor noted¹, is encouraged by lots of services like Travis CI and Heroku and EC2. It also means credentials are not visible in the output of `ps`, which is important for running on shared hosts. Unresolved is how to programmatically describe the requirements on the "envdir" module. This is an unresolved question for build requirements in general.² It may be that we sidestep that by accessing envdir through a nextstrain.build module that's always required to be available, as described in a proposal for refactoring shared functions.³ ¹ #4 ² #3 ³ #2
- Loading branch information
Showing
4 changed files
with
14 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# This file serves to ignore required-but-sensitive environment variables as | ||
# well as to preserve the containing empty directory in the git repo. | ||
|
||
/RETHINK_AUTH_KEY | ||
/RETHINK_HOST |