-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect /docs and /help to docs.nextstrain.org #226
Conversation
send /docs and /help individual pages to their corresponding pages on docs.nextstrain.org
@@ -2,6 +2,7 @@ | |||
author: "James Hadfield" | |||
date: "2019-10-21" | |||
title: "Auspice v2 released" | |||
anchorText: "Auspice v2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's necessary to have at least one instance of anchorText
or else gatsby will complain.
Upon or before merging, we'll want to remove the banner from the docs.nextstrain.org home page (https://github.com/nextstrain/docs.nextstrain.org/blob/master/src/index.rst) that says:
Since going to nextstrain.org/docs will redirect back to docs.nextstrain.org. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @eharkins - have left specific line-comments for minor changes. Thanks!
@jameshadfield 4d30a24 should resolve all of the above, let me know if it's not the case, thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging nextstrain/docs.nextstrain.org#36 would / will mean some updates are needed here. Since there were only a few changes I just added them in comment suggestions which we can add, instead of creating yet another PR into this one.
Update links according to URLs resulting from the merging of nextstrain/docs.nextstrain.org#36
Description of proposed changes
As per nextstrain/docs.nextstrain.org#13, we need to send what used to be nextstrain.org/docs and nextstrain.org/help both over to docs.nextstrain.org since we are migrating our documentation there. This does that in three steps:
Related issue(s)
nextstrain/docs.nextstrain.org#13
nextstrain/docs.nextstrain.org#35 (in case we want to adjust redirects for clade labeling page)
Testing
I've just been testing this locally with gatsby (
npm run dev
instatic-site
andnpm run server
from the root directory), checking that redirects work and clicking on external links to docs.nextstrain.org. I will deploy this on heroku to test today.