Rework attributes in pathogen.json #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-aksamentov
temporarily deployed
to
refs/pull/97/merge
GitHub Actions
Inactive
ivan-aksamentov
changed the title
ivan-aksamentov
force-pushed
the
feat/another-dataset-format
branch
from
a1ab46e to
1540e2e
Compare
ivan-aksamentov
temporarily deployed
to
refs/pull/97/merge
GitHub Actions
Inactive
ivan-aksamentov
added a commit
to nextstrain/nextclade
that referenced
this pull request
Oct 24, 2023
ivan-aksamentov
added a commit
to nextstrain/nextclade
that referenced
this pull request
Oct 24, 2023
ivan-aksamentov
added a commit
to nextstrain/nextclade
that referenced
this pull request
Oct 24, 2023
ivan-aksamentov
temporarily deployed
to
refs/pull/97/merge
GitHub Actions
Inactive
ivan-aksamentov
temporarily deployed
to
refs/pull/97/merge
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling PR in software: nextstrain/nextclade#1290
Attributes is now a simple dict of strings, anything can be in it. The non-friendly name field is removed (it's no longer in use). Our 3 remaining old attributes might be treated in a special way in UI, and the rest of attributes (which authors might add freely) will be displayed as key-value pairs in some way.
I added
metasection, which contains author info: source code URL, bugreport URL, list of strings for authors (e.g. in John Doe<[email protected]>or John Doe<https://john-doe.website.org>format).