Cleanup datasets #95
Merged
Cleanup datasets #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-aksamentov
had a problem deploying
to
refs/pull/95/merge
GitHub Actions
Failure
ivan-aksamentov
force-pushed
the
cleanup-datasets
branch
from
47dd3ca to
4bff341
Compare
ivan-aksamentov
had a problem deploying
to
refs/pull/95/merge
GitHub Actions
Failure
Here I cleanup datasets: - If I don't recognize a dataset or if I know that it is incorrect, I removed it. - I give friendly names to the remaining datasets, mostly according to what's written in their reference fasta file. - I try to make directory structure and naming a little more consistent (it is now reflected in the dataset `path` which is used as an identifier of the dataset in many places exposed to the end user). This is mostly a "cosmetic" change, needed for testing usability of the current Nextclade Web UI and for making it prettier. I have little knowledge in most of these pathogens, so this PR can be rolled back and the reorganization can be done properly by a scientists later.
ivan-aksamentov
force-pushed
the
cleanup-datasets
branch
from
4bff341 to
6d51b9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I cleanup datasets:
pathwhich is used as an identifier of the dataset in many places exposed to the end user).This is mostly a "cosmetic" change, needed for testing usability of the current Nextclade Web UI and for making it prettier.
I have little knowledge in most of these pathogens, so this PR can be rolled back and the reorganization can be done properly by a scientists later.