Trying out a reference-only dataset #124
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusroemer
had a problem deploying
to
refs/pull/124/merge
GitHub Actions
Failure
corneliusroemer
temporarily deployed
to
refs/pull/124/merge
GitHub Actions
Inactive
corneliusroemer
deployed
to
refs/pull/124/merge
GitHub Actions
Active
Comment on lines
71
to
75
| "meta": { | ||
| "name": name, | ||
| "length": len(ref.seq), | ||
| "nMinimizers": len(minimizers) | ||
| "nMinimizers": len(minimizers) + 1 # +1 to not divide by zero | ||
| } |
There was a problem hiding this comment.
There is Rust version of this algorithm on the receiver end. I am not sure how it affects it.
There must be a way to do this without a hack.
There was a problem hiding this comment.
It just decreases normalized scores a little, as the score is a heuristic it should be fine
ivan-aksamentov
force-pushed
the
master
branch
7 times, most recently
from
95a53e0 to
9170a53
Compare
ivan-aksamentov
force-pushed
the
master
branch
14 times, most recently
from
df8b4fd to
9357068
Compare
ivan-aksamentov
force-pushed
the
master
branch
7 times, most recently
from
7fcea3b to
b59f2dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test via: https://nextclade-git-cds-error-nextstrain.vercel.app/?dataset-server=gh:@scratch@&dataset-name=nextstrain/scratch/reference-only