-
Notifications
You must be signed in to change notification settings - Fork 61
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: warn when standalone ref and tree ref don't match exactly
Following conversation in #1455 (comment) Let's add a warning if the reference sequence provided any of the possible ways (fasta in dataset files, through CLI argument, Web URL param, or Web "Customization" interface) does not exactly match (as in string comparison) the `.root_sequence.nuc` in Auspice JSON. The warning message is the following. Please suggest improvements (paste a full quote into reply message or feel free to modify in the code). <details> <summary>Click to expand</summary> > Nextclade detected that reference sequence provided does not exactly match reference (root) sequence in Auspice JSON. > > This could be due to one of the reasons: > > - Nextclade dataset author provided reference sequence and reference tree that are incompatible > - The reference tree has been constructed incorrectly > - The reference sequence provided using `--input-ref` CLI argument is not compatible with the reference tree in the dataset > - The reference tree provided using `--input-tree` CLI argument is not compatible with the reference sequence in the dataset > - The reference sequence provided using `&input-ref` parameter in Nextclade Web URL is not compatible with the reference tree in the dataset > - The reference tree provided using `&input-tree` parameter in Nextclade Web URL is not compatible with the reference sequence in the dataset > > This warning signals that there is a potential for failures if the mismatch is not intended. </details>
- Loading branch information
1 parent
1aaa360
commit f35722f
Showing
3 changed files
with
78 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters