-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename template_narrative and fix dataset links [#1135] #1138
Conversation
I was checking to see if we can view the narrative on the branch: https://nextstrain.org/community/narratives/nextstrain/ncov@fix-narrative-1135/template_narrative -> shows a Bad Request https://nextstrain.org/community/narratives/nextstrain/ncov@fix-narrative-1135/template/narrative -> shows error accessing dataset, but at least it's a different error! |
Ah, the error is related to nextstrain/nextstrain.org#858. https://nextstrain.org/ncov/global?legend=closed -> https://nextstrain.org/ncov/gisaid/global/6m?legend=closed |
To comply with [file naming convention](https://github.com/nextstrain/nextstrain.org/blob/ceb01dc3740f89ca9f6b47db63f069485b0969fd/src/sources/community.js#L197-L199) for narratives and [Charon's lack of respect for redirection](nextstrain/nextstrain.org#858).
65c0f8e
to
1fecf1c
Compare
Thanks now it works! |
...now that I've merged this and the branch isn't present any more, what should be the correct link isn't working. I've tried https://next.nextstrain.org/community/narratives/nextstrain/ncov/template_narrative |
The correct link is now https://nextstrain.org/community/narratives/nextstrain/ncov/template/narrative I often forget and just go to the main community page to click on the link listed in https://nextstrain.org/community/nextstrain/ncov |
Thanks!
I will say that the mismatch between the URL and the file name strikes me as a potentially vast source of misunderstanding and frustration. |
The docs explain these technical details, but we definitely still get questions about URLs. |
The docs explain the "how?" (and thanks for linking them), but they don't address the "why?" at all, so all I can say is, "having an indirect mapping between the file name on disk and the URL seems potentially frustrating and prone to misunderstanding". 🤷 |
To comply with file naming convention for narratives and Charon's lack of respect for redirection.
Closes #1135