Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Use centralized sync-rtd-redirects workflow #1034

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Nov 29, 2022

Description of proposed changes

A central copy is easier to maintain over time now that this workflow is proliferating across our repos.

Pre-merge

Testing

  • PR dry run sync is successful
  • Other checks pass

Release checklist

N/A, internal dev change

@victorlin victorlin self-assigned this Nov 29, 2022
@victorlin victorlin marked this pull request as ready for review November 30, 2022 23:39
@victorlin victorlin force-pushed the victorlin/use-centralized-sync-rtd-redirects branch from 50dc88d to ea90312 Compare November 30, 2022 23:39
@victorlin victorlin requested a review from a team November 30, 2022 23:40
@victorlin victorlin marked this pull request as draft December 1, 2022 19:20
Copy link
Member

@tsibley tsibley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to also add:

on:
  pull_request:

since the centralized workflow now supports dry runs for PRs.

.github/workflows/sync-redirects.yaml Show resolved Hide resolved
victorlin and others added 2 commits April 9, 2024 16:25
A central copy is easier to maintain over time now that this workflow is
proliferating across our repos.
The centralized workflow now supports dry runs for PRs.

Co-authored-by: Thomas Sibley <[email protected]>
@victorlin victorlin force-pushed the victorlin/use-centralized-sync-rtd-redirects branch from ea90312 to c1ced4f Compare April 9, 2024 23:26
@victorlin
Copy link
Member Author

Might be nice to also add:

on:
  pull_request:

since the centralized workflow now supports dry runs for PRs.

Good suggestion! Added c1ced4f

@victorlin victorlin marked this pull request as ready for review April 9, 2024 23:29
@victorlin victorlin merged commit c3dfb15 into master Apr 9, 2024
15 checks passed
@victorlin victorlin deleted the victorlin/use-centralized-sync-rtd-redirects branch April 9, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants